linux-kernel - Re: [PATCH] dmaengine: fsl-edma: don't explicitly disable clocks in .remove()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <177022514793.153503.544087297189278214.b4-ty@kernel.org>
Date: Wed, 04 Feb 2026 22:42:27 +0530
From: Vinod Koul <vkoul@...nel.org>
To: Frank Li <Frank.Li@....com>, Alison Wang <b18965@...escale.com>, 
 Arnd Bergmann <arnd@...db.de>, Jingchang Lu <b35083@...escale.com>, 
 Jared Kangas <jkangas@...hat.com>
Cc: imx@...ts.linux.dev, dmaengine@...r.kernel.org, 
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: fsl-edma: don't explicitly disable clocks
 in .remove()


On Tue, 13 Jan 2026 11:46:50 -0800, Jared Kangas wrote:
> The clocks in fsl_edma_engine::muxclk are allocated and enabled with
> devm_clk_get_enabled(), which automatically cleans these resources up,
> but these clocks are also manually disabled in fsl_edma_remove(). This
> causes warnings on driver removal for each clock:
> 
>         edma_module already disabled
>         WARNING: CPU: 0 PID: 418 at drivers/clk/clk.c:1200 clk_core_disable+0x198/0x1c8
>         [...]
>         Call trace:
>          clk_core_disable+0x198/0x1c8 (P)
>          clk_disable+0x34/0x58
>          fsl_edma_remove+0x74/0xe8 [fsl_edma]
>          [...]
>         ---[ end trace 0000000000000000 ]---
>         edma_module already unprepared
>         WARNING: CPU: 0 PID: 418 at drivers/clk/clk.c:1059 clk_core_unprepare+0x1f8/0x220
>         [...]
>         Call trace:
>          clk_core_unprepare+0x1f8/0x220 (P)
>          clk_unprepare+0x34/0x58
>          fsl_edma_remove+0x7c/0xe8 [fsl_edma]
>          [...]
>         ---[ end trace 0000000000000000 ]---
> 
> [...]

Applied, thanks!

[1/1] dmaengine: fsl-edma: don't explicitly disable clocks in .remove()
      commit: 666c53e94c1d0bf0bdf14c49505ece9ddbe725bc

Best regards,
-- 
~Vinod