linux-kernel - Re: [PATCH v10 1/7] i2c: xiic: switch to devres managed APIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1B0AB3B9-A117-455B-949B-24805850AC69@nexthop.ai>
Date: Wed, 4 Feb 2026 09:59:27 -0800
From: Abdurrahman Hussain <abdurrahman@...thop.ai>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Jonathan Cameron <jonathan.cameron@...wei.com>,
 Abdurrahman Hussain via B4 Relay <devnull+abdurrahman.nexthop.ai@...nel.org>,
 Michal Simek <michal.simek@....com>,
 Andi Shyti <andi.shyti@...nel.org>,
 Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 linux-arm-kernel@...ts.infradead.org,
 linux-i2c@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH v10 1/7] i2c: xiic: switch to devres managed APIs



> On Feb 4, 2026, at 2:11 AM, Andy Shevchenko <andriy.shevchenko@...el.com> wrote:
> 
> On Wed, Feb 04, 2026 at 10:00:34AM +0000, Jonathan Cameron wrote:
>> On Wed, 04 Feb 2026 07:01:58 +0000
>> Abdurrahman Hussain via B4 Relay <devnull+abdurrahman.nexthop.ai@...nel.org> wrote:
> 
> ...
> 
>>> - return 0;
>>> -
>>> -err_pm_disable:
>>> - pm_runtime_disable(&pdev->dev);
>>> - pm_runtime_set_suspended(&pdev->dev);
>>> -
>>> return ret;
>> Trivial but if you are respinning...
>> If you get here we know ret must be 0, so make that explicit to the reader as it
>> was before with
>> return 0;
> 
>> Otherwise they need to look up a few lines to realize that is true.
> 
> Right and this is already the line above, just wrong one was removed.
> 
> ...
> 
>>> - pm_runtime_disable(&pdev->dev);
>>> - pm_runtime_set_suspended(&pdev->dev);
>>> pm_runtime_dont_use_autosuspend(&pdev->dev);
>> 
>> Take a look at docs for the devm_runtime_enable() that is called
>> by the cleanup for devm_pm_runtime_set_active_enabled()
>> 
>> Short story, it will call pm_runtime_dont_use_autosuspend() for you
> 
> Good catch! It's not obvious from the devm_pm_*() naming... :-(
> 
> ...
> 
> This definitely means v11 should be send at some point, but,
> Abdurrahman, do not hurry with it, this series missed the cycle
> anyway, we have a few *weeks* to polish this.
> 
> That said, send it after v6.20-rc1 (or v7.0-rc1) is out.
> 

Sounds good. Thank you for your patience!