linux-kernel - Re: [PATCH v14 00/26] zswap compression batching with optimized iaa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nlsqmn3x56ug7vfxw3vmpsmlyc6sie2plr22hpu7q6j7jq3adx@jbgg7sza67mv>
Date: Wed, 4 Feb 2026 18:21:43 +0000
From: Yosry Ahmed <yosry.ahmed@...ux.dev>
To: Kanchana P Sridhar <kanchana.p.sridhar@...el.com>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org, hannes@...xchg.org, 
	nphamcs@...il.com, chengming.zhou@...ux.dev, usamaarif642@...il.com, 
	ryan.roberts@....com, 21cnbao@...il.com, ying.huang@...ux.alibaba.com, 
	akpm@...ux-foundation.org, senozhatsky@...omium.org, sj@...nel.org, kasong@...cent.com, 
	linux-crypto@...r.kernel.org, herbert@...dor.apana.org.au, davem@...emloft.net, 
	clabbe@...libre.com, ardb@...nel.org, ebiggers@...gle.com, surenb@...gle.com, 
	kristen.c.accardi@...el.com, vinicius.gomes@...el.com, giovanni.cabiddu@...el.com, 
	wajdi.k.feghali@...el.com
Subject: Re: [PATCH v14 00/26] zswap compression batching with optimized
 iaa_crypto driver

On Sat, Jan 24, 2026 at 07:35:11PM -0800, Kanchana P Sridhar wrote:
[..] 

I think this series is really hard to move and respin in its current
form.

Herbert, could we take in the crypto patches separately (if they are
ready)? Not sure if it's better to take them through the crypto tree
(and provide a tag for Andrew?), or through the mm tree. But either way,
most review is on the later zswap patches and respinning all these
crypto patch every time is a pain.

> 
> Kanchana P Sridhar (26):
>   crypto: iaa - Reorganize the iaa_crypto driver code.
>   crypto: iaa - Replace sprintf with sysfs_emit in sysfs show functions
>   crypto: iaa - New architecture for IAA device WQ [de]comp usage & core
>     mapping.
>   crypto: iaa - Simplify, consistency of function parameters, minor
>     stats bug fix.
>   crypto: iaa - Descriptor allocation timeouts with mitigations.
>   crypto: iaa - iaa_wq uses percpu_refs for get/put reference counting.
>   crypto: iaa - Simplify the code flow in iaa_compress() and
>     iaa_decompress().
>   crypto: iaa - Refactor hardware descriptor setup into separate
>     procedures.
>   crypto: iaa - Simplified, efficient job submissions for non-irq mode.
>   crypto: iaa - Deprecate exporting add/remove IAA compression modes.
>   crypto: iaa - Expect a single scatterlist for a [de]compress request's
>     src/dst.
>   crypto: iaa - Rearchitect iaa_crypto to have clean interfaces with
>     crypto_acomp.
>   crypto: acomp - Define a unit_size in struct acomp_req to enable
>     batching.
>   crypto: acomp - Add bit to indicate segmentation support
>   crypto: acomp - Add trivial segmentation wrapper
>   crypto: iaa - IAA Batching for parallel compressions/decompressions.
>   crypto: iaa - Submit the two largest source buffers first in batch
>     decompress.
>   crypto: acomp, iaa - crypto_acomp integration of IAA Batching.
>   crypto: iaa - Enable async mode and make it the default.
>   crypto: iaa - Disable iaa_verify_compress by default.
>   crypto: iaa - Add deflate-iaa-dynamic compression mode.
>   crypto: acomp - Add crypto_acomp_batch_size() to get an algorithm's
>     batch-size.
>   mm: zswap: Tie per-CPU acomp_ctx lifetime to the pool.
>   mm: zswap: Consistently use IS_ERR_OR_NULL() to check acomp_ctx
>     resources.

Andrew, I think this two zswap patches are in good shape, and are
standalone improvements. Do they apply to mm-unstable? Could we take
them in separately to lighten the load of respinning this?

>   mm: zswap: Store large folios in batches.
>   mm: zswap: Batched zswap_compress() for compress batching of large
>     folios.
> 
>  .../driver-api/crypto/iaa/iaa-crypto.rst      |  168 +-
>  crypto/acompress.c                            |  110 +-
>  crypto/testmgr.c                              |   10 +
>  crypto/testmgr.h                              |   74 +
>  drivers/crypto/intel/iaa/Makefile             |    4 +-
>  drivers/crypto/intel/iaa/iaa_crypto.h         |   95 +-
>  .../intel/iaa/iaa_crypto_comp_dynamic.c       |   22 +
>  drivers/crypto/intel/iaa/iaa_crypto_main.c    | 2926 ++++++++++++-----
>  drivers/crypto/intel/iaa/iaa_crypto_stats.c   |    8 +
>  drivers/crypto/intel/iaa/iaa_crypto_stats.h   |    2 +
>  include/crypto/acompress.h                    |   68 +
>  include/crypto/algapi.h                       |    5 +
>  include/crypto/internal/acompress.h           |   15 +
>  include/linux/crypto.h                        |    3 +
>  mm/zswap.c                                    |  724 ++--
>  15 files changed, 3144 insertions(+), 1090 deletions(-)
>  create mode 100644 drivers/crypto/intel/iaa/iaa_crypto_comp_dynamic.c
> 
> -- 
> 2.27.0
>