| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <x3zr4itzvlmx7uwcnfpsiqpf7rvvdcmr3gsp22p3aqf2g7eeky@qrxvrm2lr33r>
Date: Wed, 4 Feb 2026 21:40:35 +0200
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Krishna Kurapati <krishna.kurapati@....qualcomm.com>
Cc: Swati Agarwal <swati.agarwal@....qualcomm.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Icenowy Zheng <uwu@...nowy.me>,
Matthias Kaehlcke <mka@...omium.org>,
Mike Looijmans <mike.looijmans@...ic.nl>,
Stephen Boyd <swboyd@...omium.org>,
Jens Glathe <jens.glathe@...schoolsolutions.biz>,
Chaoyi Chen <chaoyi.chen@...k-chips.com>,
J. Neuschäfer <j.ne@...teo.net>,
Pin-yen Lin <treapking@...omium.org>,
Catalin Popescu <catalin.popescu@...ca-geosystems.com>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>, linux-usb@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v5 4/4] arm64: dts: qcom: lemans-evk: Enable secondary
USB controller in host mode
On Thu, Feb 05, 2026 at 12:37:25AM +0530, Krishna Kurapati wrote:
>
>
> On 2/4/2026 4:02 PM, Dmitry Baryshkov wrote:
> > On Wed, Feb 04, 2026 at 11:26:37AM +0530, Krishna Kurapati wrote:
> > >
> > >
> > > On 2/4/2026 7:03 AM, Dmitry Baryshkov wrote:
> > > > On Tue, Jan 27, 2026 at 10:53:46AM +0530, Swati Agarwal wrote:
> > > > > On Thu, Jan 22, 2026 at 4:02 PM Dmitry Baryshkov
> > > > > <dmitry.baryshkov@....qualcomm.com> wrote:
> > > > > >
> > > > > > On Thu, Jan 22, 2026 at 02:58:52PM +0530, Swati Agarwal wrote:
> > > > > > > Enable secondary USB controller in host mode on lemans EVK Platform.
> > > > > > >
> > > > > > > Secondary USB controller is connected to a Genesys Logic USB HUB GL3590
> > > > > > > having 4 ports. The ports of hub that are present on lemans EVK standalone
> > > > > > > board are used as follows:-
> > > > > > > 1) port-1 is connected to HD3SS3220 Type-C port controller.
> > > > > > > 2) port-4 is used for the M.2 E key on corekit. Standard core kit uses UART
> > > > > > > for Bluetooth. This port is to be used only if user optionally replaces the
> > > > > > > WiFi card with the NFA765 chip which uses USB for Bluetooth.
> > > > > > >
> > > > > > > Remaining 2 ports will become functional when the interface plus mezzanine
> > > > > > > board is stacked on top of corekit:
> > > > > > >
> > > > > > > 3) port-2 is connected to another hub which is present on the mezz through
> > > > > > > which 4 type-A ports are connected.
> > > > > > > 4) port-3 is used for the M.2 B key for a 5G card when the mezz is
> > > > > > > connected.
> > > > > > >
> > > > > > > Mark the second USB controller as host only capable and add the HD3SS3220
> > > > > > > Type-C port controller along with Type-c connector for controlling vbus
> > > > > > > supply.
> > > > > > >
> > > > > > > Signed-off-by: Swati Agarwal <swati.agarwal@....qualcomm.com>
> > > > > > > ---
> > > > > > > arch/arm64/boot/dts/qcom/lemans-evk.dts | 208 ++++++++++++++++++++++++
> > > > > > > 1 file changed, 208 insertions(+)
> > > > > > >
> > > > > > > diff --git a/arch/arm64/boot/dts/qcom/lemans-evk.dts b/arch/arm64/boot/dts/qcom/lemans-evk.dts
> > > > > > > index 074a1edd0334..a549f7fe53a1 100644
> > > > > > > --- a/arch/arm64/boot/dts/qcom/lemans-evk.dts
> > > > > > > +++ b/arch/arm64/boot/dts/qcom/lemans-evk.dts
> > > > > > > @@ -68,6 +68,45 @@ usb0_con_ss_ep: endpoint {
> > > > > > > };
> > > > > > > };
> > > > > > >
> > > > > > > + connector-1 {
> > > > > > > + compatible = "usb-c-connector";
> > > > > > > + label = "USB1-Type-C";
> > > > > > > + data-role = "host";
> > > > > > > + power-role = "source";
> > > > > > > +
> > > > > > > + vbus-supply = <&vbus_supply_regulator_1>;
> > > > > > > +
> > > > > > > + ports {
> > > > > > > + #address-cells = <1>;
> > > > > > > + #size-cells = <0>;
> > > > > > > +
> > > > > > > + port@0 {
> > > > > > > + reg = <0>;
> > > > > > > +
> > > > > > > + usb1_con_ss_ep: endpoint {
> > > > > >
> > > > > > This contradicts USB-C connector bindings. Why?
> > > > > >
> > > > > > > + remote-endpoint = <&hd3ss3220_1_in_ep>;
> > > > > > > + };
> > > > > > > + };
> > > > > > > +
> > > > > > > + port@1 {
> > > > > > > + reg = <1>;
> > > > > > > +
> > > > > > > + usb1_hs_in: endpoint {
> > > > > > > + remote-endpoint = <&usb_hub_2_1>;
> > > > > > > + };
> > > > > > > +
> > > > > > > + };
> > > > > > > +
> > > > > > > + port@2 {
> > > > > > > + reg = <2>;
> > > > > > > +
> > > > > > > + usb1_ss_in: endpoint {
> > > > > >
> > > > > > port@2 is for the SBU signals. It can't be connected to the hub.
> > > > > >
> > > > > > > + remote-endpoint = <&usb_hub_3_1>;
> > > > > > > + };
> > > > > > > + };
> > > > > > > + };
> > > > > > > + };
> > > > > > > +
> > > > > > > edp0-connector {
> > > > > > > compatible = "dp-connector";
> > > > > > > label = "EDP0";
> > > > > > > @@ -141,6 +180,16 @@ vbus_supply_regulator_0: regulator-vbus-supply-0 {
> > > > > > > enable-active-high;
> > > > > > > };
> > > > > > >
> > > > > > > + vbus_supply_regulator_1: regulator-vbus-supply-1 {
> > > > > > > + compatible = "regulator-fixed";
> > > > > > > + regulator-name = "vbus_supply_1";
> > > > > > > + gpio = <&expander1 3 GPIO_ACTIVE_HIGH>;
> > > > > > > + regulator-min-microvolt = <5000000>;
> > > > > > > + regulator-max-microvolt = <5000000>;
> > > > > > > + regulator-boot-on;
> > > > > > > + enable-active-high;
> > > > > > > + };
> > > > > > > +
> > > > > > > vmmc_sdc: regulator-vmmc-sdc {
> > > > > > > compatible = "regulator-fixed";
> > > > > > >
> > > > > > > @@ -536,6 +585,39 @@ hd3ss3220_0_out_ep: endpoint {
> > > > > > > };
> > > > > > > };
> > > > > > > };
> > > > > > > +
> > > > > > > + usb-typec@47 {
> > > > > > > + compatible = "ti,hd3ss3220";
> > > > > > > + reg = <0x47>;
> > > > > > > +
> > > > > > > + interrupts-extended = <&pmm8654au_2_gpios 6 IRQ_TYPE_EDGE_FALLING>;
> > > > > > > +
> > > > > > > + id-gpios = <&tlmm 51 GPIO_ACTIVE_HIGH>;
> > > > > > > +
> > > > > > > + pinctrl-0 = <&usb1_id>, <&usb1_intr>;
> > > > > > > + pinctrl-names = "default";
> > > > > > > +
> > > > > > > + ports {
> > > > > > > + #address-cells = <1>;
> > > > > > > + #size-cells = <0>;
> > > > > > > +
> > > > > > > + port@0 {
> > > > > > > + reg = <0>;
> > > > > > > +
> > > > > > > + hd3ss3220_1_in_ep: endpoint {
> > > > > > > + remote-endpoint = <&usb1_con_ss_ep>;
> > > > > > > + };
> > > > > > > + };
> > > > > > > +
> > > > > > > + port@1 {
> > > > > > > + reg = <1>;
> > > > > > > +
> > > > > > > + hd3ss3220_1_out_ep: endpoint {
> > > > > > > + };
> > > > > >
> > > > > > Why is this port disconnected? It it really N/C?
> > > > >
> > > > > Hi Dmitry,
> > > > >
> > > > > Sorry for the confusion, Can we do it as follows:
> > > > >
> > > > > hub: Hd3ss3220 typec-connector
> > > > >
> > > > > usb_hub_2_1 <-> port@1 port@1 <-> empty
> > > > > usb_hub_3_1 <-> port@2 port@2 <-> <empty>
> > > > > port@0 <-> port@0
> > > > >
> > > >
> > > > You still missed the _why_. Why port@1 of HD3SS3220 is not connected?
> > > >
> > >
> > > There are no remote endpoints added in dwc3 node. Since we are making
> > > dr_mode host. Hence keeping this remore endpoint empty.
> >
> > How is the link between HD3SS3220 and Type-C affected by the DWC3? What
> > does port@1 of it represent? Do we have SS lanes between HD3SS3220 and
> > the connector?
> >
>
> Yes.
>
> The lines go from Soc -> Hub -> Port controller -> Connector
>
> Hence I didn't add any special endpoint mapping between usb controller and
> port controller in above provided diagram.
>
> One port of port-controller goes to connector and the other goes to where
> the lanes are coming from. Usually its only one endpoint from dwc3 usb
> controller to hd3 port-controller. In this case, since its a hub, we added
> two ports (one for Hs and the other for ss lines) to hd3 port controller.
One needs to describe both HS and SS lanes being routed to the Type-C
connector. Please make sure that all signals are described.
--
With best wishes
Dmitry
Powered by blists - more mailing lists