linux-kernel - Re: [PATCH] hwmon: (occ) Mark occ_init_attribute() as _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ad405e7a-6797-4b5c-9cd0-76bd9a1a8121@roeck-us.net>
Date: Wed, 4 Feb 2026 14:40:51 -0800
From: Guenter Roeck <linux@...ck-us.net>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Arnd Bergmann <arnd@...db.de>, linux-hwmon@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwmon: (occ) Mark occ_init_attribute() as __printf

On Tue, Feb 03, 2026 at 05:34:36PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> This is a printf-style function, which gcc -Werror=suggest-attribute=format
> correctly points out:
> 
> drivers/hwmon/occ/common.c: In function 'occ_init_attribute':
> drivers/hwmon/occ/common.c:761:9: error: function 'occ_init_attribute' might be a candidate for 'gnu_printf' format attribute [-Werror=suggest-attribute=format]
> 
> Add the attribute to avoid this warning and ensure any incorrect
> format strings are detected here.
> 
> Fixes: 744c2fe950e9 ("hwmon: (occ) Rework attribute registration for stack usage")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied.

Thanks,
Guenter