linux-kernel - Re: [PATCH v2] fs: hugetlb: simplify remove_inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20260204144442.4eb44f4bb933daed44d5db96@linux-foundation.org>
Date: Wed, 4 Feb 2026 14:44:42 -0800
From: Andrew Morton <akpm@...ux-foundation.org>
To: "David Hildenbrand (arm)" <david@...nel.org>
Cc: Jiaqi Yan <jiaqiyan@...gle.com>, jane.chu@...cle.com,
 muchun.song@...ux.dev, osalvador@...e.de, william.roche@...cle.com,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] fs: hugetlb: simplify remove_inode_hugepages()
 return type

On Wed, 4 Feb 2026 22:54:48 +0100 "David Hildenbrand (arm)" <david@...nel.org> wrote:

> > Changelog
> > =========
> > 
> > v2 -> v1 [2]
> > 
> > - Use two-tab alignment for parameters wrapped to new lines.
> > 
> > - Remove return type in remove_inode_hugepages()'s comment.
> > 
> > [1] https://lore.kernel.org/all/20220914221810.95771-10-mike.kravetz@oracle.com
> > [2] https://lore.kernel.org/linux-mm/20260202233617.2350734-1-jiaqiyan@google.com
> > 
> > Suggested-by: Jane Chu <jane.chu@...cle.com>
> > Reviewed-by: Jane Chu <jane.chu@...cle.com>
> > Reviewed-by: Muchun Song <muchun.song@...ux.dev>
> > Acked-by: David Hildenbrand (arm) <david@...nel.org>
> > Signed-off-by: Jiaqi Yan <jiaqiyan@...gle.com>
> > ---
> 
> For the future, the changelog always belongs down here, under the ---, like
> 
> Signed-off-by: Jiaqi Yan <jiaqiyan@...gle.com>
> ---
> 
> Changelog
> ...
> 
>   fs/hugetlbfs/inode.c | 18 ++++++------------
>   1 file changed, 6 insertions(+), 12 deletions(-)
> 
> I think I always add another "---" above the file list, not sure if that 
> is required.

Interpretations might vary but the "^---$" inventor sayeth that
everything below the "^---$" is not part of the changelog and is to be
removed.


Also, my preference is that the permanent upstreamable changelog not
contain short-term development-time information, as that's
uninteresting to someone who is looking at the commit three years from
now.

Material such as "how this patch differes from the previous version"
and "how I tested it" is interesting and useful, but below the "^---$",
please.


Beware that git interprets the separator more loosely: "^-----------"
will match.  So using a row of "-" characters to underline a heading is
a pitfall.