linux-kernel - Re: [PATCH net 3/3] net: ag71xx: call phylink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260203193250.6059a63c@kernel.org>
Date: Tue, 3 Feb 2026 19:32:50 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Rosen Penev <rosenp@...il.com>
Cc: netdev@...r.kernel.org, Chris Snook <chris.snook@...il.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Russell
 King <linux@...linux.org.uk> (maintainer:SFF/SFP/SFP+ MODULE
 SUPPORT:Keyword:phylink\.h|struct\s+phylink|\.phylink|>,
 linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH net 3/3] net: ag71xx: call phylink_destroy on failure

On Mon,  2 Feb 2026 13:46:34 -0800 Rosen Penev wrote:
> phylink_create has no devm equivalent and must therefore be handled
> manually in probe and remove.
> 
> Signed-off-by: Rosen Penev <rosenp@...il.com>

Missing a fixes tag. Also missing (in patch 1) the ability to compile.

I defer to the phy folks on the question of using
devm_add_action_or_reset
-- 
pw-bot: cr