linux-kernel - Re: [PATCH] workqueue: rust: add work item runtime modification support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202602040543.4ixOmzHo-lkp@intel.com>
Date: Wed, 4 Feb 2026 05:54:23 +0100
From: kernel test robot <lkp@...el.com>
To: Hamza Mahfooz <hamzamahfooz@...ux.microsoft.com>,
	rust-for-linux@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, Miguel Ojeda <ojeda@...nel.org>,
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <lossin@...nel.org>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>,
	Danilo Krummrich <dakr@...nel.org>, Tejun Heo <tj@...nel.org>,
	Tamir Duberstein <tamird@...il.com>, Alban Kurti <kurti@...icto.ai>,
	linux-kernel@...r.kernel.org,
	Hamza Mahfooz <hamzamahfooz@...ux.microsoft.com>
Subject: Re: [PATCH] workqueue: rust: add work item runtime modification
 support

Hi Hamza,

kernel test robot noticed the following build warnings:

[auto build test WARNING on rust/rust-next]
[also build test WARNING on next-20260203]
[cannot apply to linus/master v6.16-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Hamza-Mahfooz/workqueue-rust-add-work-item-runtime-modification-support/20260204-060728
base:   https://github.com/Rust-for-Linux/linux rust-next
patch link:    https://lore.kernel.org/r/20260203215555.832171-1-hamzamahfooz%40linux.microsoft.com
patch subject: [PATCH] workqueue: rust: add work item runtime modification support
config: x86_64-rhel-9.4-rust (https://download.01.org/0day-ci/archive/20260204/202602040543.4ixOmzHo-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
rustc: rustc 1.88.0 (6b00bc388 2025-06-23)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260204/202602040543.4ixOmzHo-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602040543.4ixOmzHo-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> warning: unsafe function's docs are missing a `# Safety` section
   --> rust/kernel/workqueue.rs:443:5
   |
   443 | /     unsafe fn __enqueue_delayed<F>(self, queue_work_on: F) -> Self::EnqueueDelayedOutput
   444 | |     where
   445 | |         F: FnOnce(*mut bindings::work_struct) -> bool;
   | |______________________________________________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
   = note: `-W clippy::missing-safety-doc` implied by `-W clippy::all`
   = help: to override `-W clippy::all` add `#[allow(clippy::missing_safety_doc)]`
--
>> warning: unsafe function's docs are missing a `# Safety` section
   --> rust/kernel/workqueue.rs:558:5
   |
   558 |     pub unsafe fn raw_enable(this: *const Self) -> bool {
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
--
>> warning: unsafe function's docs are missing a `# Safety` section
   --> rust/kernel/workqueue.rs:582:5
   |
   582 |     pub unsafe fn raw_disable_sync(this: *const Self) -> bool {
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
--
>> warning: unsafe function's docs are missing a `# Safety` section
   --> rust/kernel/workqueue.rs:588:5
   |
   588 |     pub unsafe fn raw_disable_delayed_sync(this: *const Self) -> bool {
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
--
>> warning: unsafe function's docs are missing a `# Safety` section
   --> rust/kernel/workqueue.rs:594:5
   |
   594 |     pub unsafe fn raw_cancel(this: *const Self) -> bool {
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
--
>> warning: unsafe function's docs are missing a `# Safety` section
   --> rust/kernel/workqueue.rs:600:5
   |
   600 |     pub unsafe fn raw_cancel_delayed(this: *const Self) -> bool {
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
--
>> warning: unsafe function's docs are missing a `# Safety` section
   --> rust/kernel/workqueue.rs:606:5
   |
   606 |     pub unsafe fn raw_cancel_sync(this: *const Self) -> bool {
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
--
>> warning: unsafe function's docs are missing a `# Safety` section
   --> rust/kernel/workqueue.rs:612:5
   |
   612 |     pub unsafe fn raw_cancel_delayed_sync(this: *const Self) -> bool {
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
--
>> warning: docs for unsafe trait missing `# Safety` section
   --> rust/kernel/workqueue.rs:664:1
   |
   664 | pub unsafe trait WorkHandle {
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
--
>> warning: unsafe impl missing a safety comment
   --> rust/kernel/workqueue.rs:702:1
   |
   702 | unsafe impl<T, const ID: u64> WorkHandle for ArcWorkHandle<T, ID>
   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: consider adding a safety comment on the preceding line
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#undocumented_unsafe_blocks
--
>> warning: unsafe function's docs are missing a `# Safety` section
   --> rust/kernel/workqueue.rs:564:5
   |
   564 |     pub unsafe fn raw_disable(this: *const Self) -> bool {
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc
..

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki