linux-kernel - Re: [PATCH v1] hugetlb: simplify remove_inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <B6A091A5-B25E-41CB-8882-493E006A0BE7@linux.dev>
Date: Wed, 4 Feb 2026 14:06:14 +0800
From: Muchun Song <muchun.song@...ux.dev>
To: Jiaqi Yan <jiaqiyan@...gle.com>
Cc: jane.chu@...cle.com,
 osalvador@...e.de,
 david@...nel.org,
 william.roche@...cle.com,
 linux-mm@...ck.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] hugetlb: simplify remove_inode_hugepages() return type



> On Feb 3, 2026, at 07:36, Jiaqi Yan <jiaqiyan@...gle.com> wrote:
> 
> When remove_inode_hugepages is introduced in
> commit c86272287bc6 ("hugetlb: create remove_inode_single_folio to remove single file folio")
> it used to return a boolean to indicate if it bailed out due to race with
> page faults. However, since the race is already solved by [1],
> remove_inode_hugepages() doesn't have any path to return false anymore.
> 
> Simplify remove_inode_hugepages() return type to void, remove the
> unnecessary ret variable, and adjust the call site in
> remove_inode_hugepages(). No functional change in this commit.
> 
> [1] https://lore.kernel.org/all/20220914221810.95771-10-mike.kravetz@oracle.com
> 
> Suggested-by: Jane Chu <jane.chu@...cle.com>
> Signed-off-by: Jiaqi Yan <jiaqiyan@...gle.com>

Reviewed-by: Muchun Song <muchun.song@...ux.dev>