linux-kernel - [PATCH] clk: versatile: vexpress-osc: Check return value of devm_of_clk_add_hw_provider() in vexpress_osc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20260204063332.1791986-1-nichen@iscas.ac.cn>
Date: Wed,  4 Feb 2026 14:33:32 +0800
From: Chen Ni <nichen@...as.ac.cn>
To: linusw@...nel.org,
	mturquette@...libre.com,
	sboyd@...nel.org,
	liviu.dudau@....com,
	sudeep.holla@...nel.org,
	lpieralisi@...nel.org,
	robh@...nel.org,
	arnd@...db.de
Cc: linux-arm-kernel@...ts.infradead.org,
	linux-clk@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Chen Ni <nichen@...as.ac.cn>
Subject: [PATCH] clk: versatile: vexpress-osc: Check return value of devm_of_clk_add_hw_provider() in vexpress_osc_probe()

Return the value of devm_of_clk_add_hw_provider() in order to propagate
the error properly, if it fails due to resource allocation failure or
device tree clock provider registration failure.

This ensures that the probe function fails safely rather than proceeding
with a potentially incomplete clock provider setup.

Fixes: 03cc105f2edf ("clk: vexpress-osc: Use the devres clock API variants")
Signed-off-by: Chen Ni <nichen@...as.ac.cn>
---
 drivers/clk/versatile/clk-vexpress-osc.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/versatile/clk-vexpress-osc.c b/drivers/clk/versatile/clk-vexpress-osc.c
index 9adbf5c33bd1..2292fee4e423 100644
--- a/drivers/clk/versatile/clk-vexpress-osc.c
+++ b/drivers/clk/versatile/clk-vexpress-osc.c
@@ -97,7 +97,10 @@ static int vexpress_osc_probe(struct platform_device *pdev)
 	if (ret < 0)
 		return ret;
 
-	devm_of_clk_add_hw_provider(&pdev->dev, of_clk_hw_simple_get, &osc->hw);
+	ret = devm_of_clk_add_hw_provider(&pdev->dev, of_clk_hw_simple_get, &osc->hw);
+	if (ret)
+		return ret;
+
 	clk_hw_set_rate_range(&osc->hw, osc->rate_min, osc->rate_max);
 
 	dev_dbg(&pdev->dev, "Registered clock '%s'\n", init.name);
-- 
2.25.1