[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20260204074909.GC1632007@ax162>
Date: Wed, 4 Feb 2026 00:49:09 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Masahiro Yamada <masahiroy@...nel.org>
Cc: Miguel Ojeda <ojeda@...nel.org>, Matthew Maurer <mmaurer@...gle.com>,
linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
rust-for-linux@...r.kernel.org
Subject: Re: [PATCH] rust: kconfig: Don't require RUST_IS_AVAILABLE for
rustc-option
On Wed, Feb 04, 2026 at 04:17:26PM +0900, Masahiro Yamada wrote:
> On Wed, Feb 4, 2026 at 9:16 AM Nathan Chancellor <nathan@...nel.org> wrote:
> >
> > On Tue, 09 Sep 2025 18:14:20 +0000, Matthew Maurer wrote:
> > > The final version of this macro does not fail in the absence of an
> > > invokable `$(RUSTC)`, so we don't need to be careful not to invoke it.
> > >
> > >
> >
> > Applied to
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/kbuild/linux.git kbuild-next
> >
> > Thanks!
> >
> > [1/1] rust: kconfig: Don't require RUST_IS_AVAILABLE for rustc-option
> > https://git.kernel.org/kbuild/c/f2445d6f264c6
> >
> > Please look out for regression or issue reports or other follow up
> > comments, as they may result in the patch/series getting dropped or
> > reverted. Patches applied to an "unstable" branch are accepted pending
> > wider testing in -next and any post-commit review; they will generally
> > be moved to the main branch in a week if no issues are found.
> >
> > Best regards,
> > --
> > Nathan Chancellor <nathan@...nel.org>
> >
> >
>
> Removing this comment is correct, but please note
> the commit description is not accurate.
>
> Kconfig evaluates all $(shell ...) macros before deciding the
> value of RUSAT_IS_AVAILABLE.
> You cannot prevent Kconfig from evaluating $(shell ...).
> The author of c42297438aee7 did not read
> Documentation/kbuild/kconfig-macro-language.rst
Ugh, yes, sorry, I should have caught that too because I just recently
looked at this in another thread :(
https://lore.kernel.org/20260129232535.GD844102@ax162/
I'd rather not rebase at this point but I appreciate you clarifying this
for the record.
Cheers,
Nathan
Powered by blists - more mailing lists