linux-kernel - Re: [PATCH v4 1/2] mtd: spi-nand: Add support for randomizer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <878qd8hpql.fsf@bootlin.com>
Date: Wed, 04 Feb 2026 09:33:54 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Cheng Ming Lin <linchengming884@...il.com>
Cc: Vignesh Raghavendra <vigneshr@...com>,  Richard Weinberger
 <richard@....at>,  Tudor Ambarus <tudor.ambarus@...aro.org>,  Martin
 Kurbanov <mmkurbanov@...utedevices.com>,  Mikhail Kshevetskiy
 <mikhail.kshevetskiy@...sys.eu>,  Pratyush Yadav <pratyush@...nel.org>,
  linux-mtd@...ts.infradead.org,  linux-kernel@...r.kernel.org,
  alvinzhou@...c.com.tw,  Cheng Ming Lin <chengminglin@...c.com.tw>
Subject: Re: [PATCH v4 1/2] mtd: spi-nand: Add support for randomizer

Hi Cheng Ming,

>> Looking at the current implementation, I really don't like the core
>> always calling in the "init" and the manufacturer driver reading the DT
>> and deciding whether or not it enables it.
>
> I agree. I will refactor the logic in v5 so that the core parses the
> generic DT properties (nand-enable-randomizer and
> nand-disable-randomizer).
>
> Then, spinand_randomizer_init will determine the state and pass a
> boolean argument to the set_randomizer callback, leaving the driver
> to strictly handle the hardware configuration.

Perfect.

Thanks,
Miquèl