linux-kernel - Re: [PATCH v1 1/1] sunrpc: Fix compilation error (`make W=1`) when dprintk() is no-op

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYMMEiNCPaJIc9Rd@smile.fi.intel.com>
Date: Wed, 4 Feb 2026 11:06:26 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Chuck Lever <chuck.lever@...cle.com>, NeilBrown <neil@...wn.name>,
	Jeff Layton <jlayton@...nel.org>, linux-nfs@...r.kernel.org,
	linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
	Olga Kornievskaia <okorniev@...hat.com>,
	Dai Ngo <Dai.Ngo@...cle.com>, Tom Talpey <tom@...pey.com>,
	Trond Myklebust <trondmy@...nel.org>,
	Anna Schumaker <anna@...nel.org>,
	Nathan Chancellor <nathan@...nel.org>,
	Nick Desaulniers <nick.desaulniers+lkml@...il.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>
Subject: Re: [PATCH v1 1/1] sunrpc: Fix compilation error (`make W=1`) when
 dprintk() is no-op

On Wed, Feb 04, 2026 at 08:53:39AM +0100, Geert Uytterhoeven wrote:
> On Wed, 4 Feb 2026 at 02:11, Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:
> > On Wed, Feb 04, 2026 at 02:04:15AM +0100, Andy Shevchenko wrote:

...

> Definitely.  I tried something similar a few years ago[1], but ran into build
> errors from the robots, and gave up due to lack of time.

For the matter of fact, I also get into errors from LKP (I compiled only part
of this, need to enable more to cover these cases).

> So for the principle:
> Acked-by: Geert Uytterhoeven <geert+renesas@...der.be>

Thanks, I will do more tests and fixes and add your Ack.

> Ah, my local tree still has the following fix I never sent out, and still
> looks suboptimal:

Right, thanks for sharing, it's the same call robots are not okay with.

-- 
With Best Regards,
Andy Shevchenko