linux-kernel - [PATCH] drm/bridge: waveshare-dsi: Return devm_drm_bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20260204090119.2209476-1-nichen@iscas.ac.cn>
Date: Wed,  4 Feb 2026 17:01:19 +0800
From: Chen Ni <nichen@...as.ac.cn>
To: andrzej.hajda@...el.com,
	neil.armstrong@...aro.org,
	rfoss@...nel.org,
	Laurent.pinchart@...asonboard.com,
	jonas@...boo.se,
	jernej.skrabec@...il.com,
	maarten.lankhorst@...ux.intel.com,
	mripard@...nel.org,
	tzimmermann@...e.de,
	airlied@...il.com,
	simona@...ll.ch,
	qijian.guo@....com
Cc: dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org,
	Chen Ni <nichen@...as.ac.cn>
Subject: [PATCH] drm/bridge: waveshare-dsi: Return devm_drm_bridge_add() to transfer the error

Return devm_drm_bridge_add() in order to transfer the error if it fails.

This ensures that the probe function fails safely rather than proceeding
with a potentially incomplete bridge setup.

Fixes: dbdea37add13 ("drm: bridge: Add waveshare DSI2DPI unit driver")
Signed-off-by: Chen Ni <nichen@...as.ac.cn>
---
 drivers/gpu/drm/bridge/waveshare-dsi.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/waveshare-dsi.c b/drivers/gpu/drm/bridge/waveshare-dsi.c
index 43f4e7412d72..e25b139b4a41 100644
--- a/drivers/gpu/drm/bridge/waveshare-dsi.c
+++ b/drivers/gpu/drm/bridge/waveshare-dsi.c
@@ -177,9 +177,8 @@ static int ws_bridge_probe(struct i2c_client *i2c)
 
 	ws->bridge.type = DRM_MODE_CONNECTOR_DPI;
 	ws->bridge.of_node = dev->of_node;
-	devm_drm_bridge_add(dev, &ws->bridge);
 
-	return 0;
+	return devm_drm_bridge_add(dev, &ws->bridge);
 }
 
 static const struct of_device_id ws_bridge_of_ids[] = {
-- 
2.25.1