linux-kernel - Re:[PATCH v2] drm/bridge: synopsys: dw-dp: Check return value of devm_drm_bridge_add() in dw_dp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <651f6165.7bb8.19c280857b2.Coremail.andyshrk@163.com>
Date: Wed, 4 Feb 2026 17:42:41 +0800 (CST)
From: "Andy Yan" <andyshrk@....com>
To: "Chen Ni" <nichen@...as.ac.cn>
Cc: Laurent.pinchart@...asonboard.com, airlied@...il.com,
	andrzej.hajda@...el.com, andy.yan@...k-chips.com,
	jernej.skrabec@...il.com, jonas@...boo.se, luca.ceresoli@...tlin.com,
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org,
	neil.armstrong@...aro.org, rfoss@...nel.org, rgallaispou@...il.com,
	simona@...ll.ch, tzimmermann@...e.de,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re:[PATCH v2] drm/bridge: synopsys: dw-dp: Check return value of
 devm_drm_bridge_add() in dw_dp_bind()



Hello，
At 2026-02-04 17:21:48, "Chen Ni" <nichen@...as.ac.cn> wrote:
>Return the value of devm_drm_bridge_add() in order to propagate the
>error properly, if it fails due to resource allocation failure or bridge
>registration failure.
>
>This ensures that the bind function fails safely rather than proceeding
>with a potentially incomplete bridge setup.
>
>Fixes: b726970486d8 ("drm/bridge: synopsys: dw-dp: add bridge before attaching")
>Signed-off-by: Chen Ni <nichen@...as.ac.cn>


   Reviewed-by: Andy Yan <andyshrk@....com>

>---
>Changes in v2:
>- Use ERR_PTR() instead of dev_err_ptr_probe().
>---
> drivers/gpu/drm/bridge/synopsys/dw-dp.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
>index 432342452484..29fcba7a47d3 100644
>--- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c
>+++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
>@@ -2049,7 +2049,11 @@ struct dw_dp *dw_dp_bind(struct device *dev, struct drm_encoder *encoder,
> 	bridge->type = DRM_MODE_CONNECTOR_DisplayPort;
> 	bridge->ycbcr_420_allowed = true;
> 
>-	devm_drm_bridge_add(dev, bridge);
>+	ret = devm_drm_bridge_add(dev, bridge);
>+	if (ret) {
>+		dev_err_probe(dev, ret, "failed to add bridge\n");
>+		return ERR_PTR(ret);
>+	}
> 
> 	dp->aux.dev = dev;
> 	dp->aux.drm_dev = encoder->dev;
>-- 
>2.25.1