linux-kernel - Re: [PATCH] staging: greybus: audio_codec.c: Remove unnecessary parentheses in if statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2026020400-unopposed-graffiti-5657@gregkh>
Date: Wed, 4 Feb 2026 10:53:36 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Eitan Collett <eitan.collett@...il.com>
Cc: Vaibhav Agarwal <vaibhav.sr@...il.com>,
	Mark Greer <mgreer@...malcreek.com>,
	Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
	greybus-dev@...ts.linaro.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: greybus: audio_codec.c: Remove unnecessary
 parentheses in if statement

On Mon, Feb 02, 2026 at 03:32:42PM +0200, Eitan Collett wrote:
> Adhere to Linux kernel coding style.
> 
> Reported by checkpatch:
> 
> CHECK: Unnecessary parentheses around 'w->id != snd_soc_dapm_aif_in'
> CHECK: Unnecessary parentheses around 'w->id != snd_soc_dapm_aif_out'
> 
> Signed-off-by: Eitan Collett <eitan.collett@...il.com>
> ---
>  drivers/staging/greybus/audio_codec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c
> index 444c53b4e08d..44aee8268d14 100644
> --- a/drivers/staging/greybus/audio_codec.c
> +++ b/drivers/staging/greybus/audio_codec.c
> @@ -305,7 +305,7 @@ int gbaudio_module_update(struct gbaudio_codec_info *codec,
>  	dev_dbg(module->dev, "%s:Module update %s sequence\n", w->name,
>  		enable ? "Enable" : "Disable");
>  
> -	if ((w->id != snd_soc_dapm_aif_in) && (w->id != snd_soc_dapm_aif_out)) {
> +	if (w->id != snd_soc_dapm_aif_in && w->id != snd_soc_dapm_aif_out) {

I hate this checkpatch "warning" sorry.  Now you need to go and try to
remember if && is higher priority than !=, right?

Please just leave this as-is.

thanks,

greg k-h