| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID:
<TY3PR01MB113467F387FE21FE26DEC5C0E8698A@TY3PR01MB11346.jpnprd01.prod.outlook.com>
Date: Wed, 4 Feb 2026 10:25:34 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
CC: Thomas Gleixner <tglx@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>,
Geert Uytterhoeven <geert+renesas@...der.be>, magnus.damm
<magnus.damm@...il.com>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, "linux-renesas-soc@...r.kernel.org"
<linux-renesas-soc@...r.kernel.org>, Fabrizio Castro
<fabrizio.castro.jz@...esas.com>, Prabhakar Mahadev Lad
<prabhakar.mahadev-lad.rj@...renesas.com>
Subject: RE: [PATCH v2 4/6] irqchip/renesas-rzv2h: Make IRQ type handling
range-aware
> -----Original Message-----
> From: Lad, Prabhakar <prabhakar.csengg@...il.com>
> Sent: 04 February 2026 10:20
> To: Biju Das <biju.das.jz@...renesas.com>
> Cc: Thomas Gleixner <tglx@...nel.org>; Philipp Zabel <p.zabel@...gutronix.de>; Geert Uytterhoeven
> <geert+renesas@...der.be>; magnus.damm <magnus.damm@...il.com>; linux-kernel@...r.kernel.org; linux-
> renesas-soc@...r.kernel.org; Fabrizio Castro <fabrizio.castro.jz@...esas.com>; Prabhakar Mahadev Lad
> <prabhakar.mahadev-lad.rj@...renesas.com>
> Subject: Re: [PATCH v2 4/6] irqchip/renesas-rzv2h: Make IRQ type handling range-aware
>
> Hi Biju,
>
> On Wed, Feb 4, 2026 at 6:52 AM Biju Das <biju.das.jz@...renesas.com> wrote:
> >
> > Hi Prabhakar,
> >
> > Thanks for the patch.
> >
> > > -----Original Message-----
> > > From: Prabhakar <prabhakar.csengg@...il.com>
> > > Sent: 03 February 2026 23:18
> > > Subject: [PATCH v2 4/6] irqchip/renesas-rzv2h: Make IRQ type
> > > handling range-aware
> > >
> > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> > >
> > > Refine IRQ type handling to explicitly bound IRQ and TINT ranges and
> > > dispatch based on the hardware IRQ number.
> > >
> > > This restructures the logic to clearly separate NMI, IRQ, and TINT
> > > handling and ensures out-of-range interrupts are ignored safely. The
> > > change prepares the driver for adding CA55 interrupts into the IRQ hierarchy domain by making the
> interrupt classification explicit and extensible.
> > >
> > > Signed-off-by: Lad Prabhakar
> > > <prabhakar.mahadev-lad.rj@...renesas.com>
> > > ---
> > > v1->v2:
> > > - New patch.
> > > ---
> > > drivers/irqchip/irq-renesas-rzv2h.c | 59
> > > +++++++++++++++++++----------
> > > 1 file changed, 40 insertions(+), 19 deletions(-)
> > >
> > > diff --git a/drivers/irqchip/irq-renesas-rzv2h.c
> > > b/drivers/irqchip/irq-renesas-rzv2h.c
> > > index 4aa772ba1a1f..6c7bbb04c6e4 100644
> > > --- a/drivers/irqchip/irq-renesas-rzv2h.c
> > > +++ b/drivers/irqchip/irq-renesas-rzv2h.c
> > > @@ -25,9 +25,11 @@
> > > /* DT "interrupts" indexes */
> > > #define ICU_IRQ_START 1
> > > #define ICU_IRQ_COUNT 16
> > > -#define ICU_TINT_START (ICU_IRQ_START + ICU_IRQ_COUNT)
> > > +#define ICU_IRQ_LAST (ICU_IRQ_START + ICU_IRQ_COUNT - 1)
> > > +#define ICU_TINT_START (ICU_IRQ_LAST + 1)
> > > #define ICU_TINT_COUNT 32
> > > -#define ICU_NUM_IRQ (ICU_TINT_START + ICU_TINT_COUNT)
> > > +#define ICU_TINT_LAST (ICU_TINT_START + ICU_TINT_COUNT - 1)
> > > +#define ICU_NUM_IRQ (ICU_TINT_LAST + 1)
> > >
> > > /* Registers */
> > > #define ICU_NSCNT 0x00
> > > @@ -175,18 +177,27 @@ static void rzv2h_icu_eoi(struct irq_data *d)
> > > u32 bit;
> > >
> > > scoped_guard(raw_spinlock, &priv->lock) {
> > > - if (hw_irq >= ICU_TINT_START) {
> > > - tintirq_nr = hw_irq - ICU_TINT_START;
> > > - bit = BIT(tintirq_nr);
> > > - if (!irqd_is_level_type(d))
> > > - writel_relaxed(bit, priv->base + priv->info->t_offs + ICU_TSCLR);
> > > - } else if (hw_irq >= ICU_IRQ_START) {
> > > + switch (hw_irq) {
> > > + case 0:
> > > + /* Clear NMI */
> > > + writel_relaxed(ICU_NSCLR_NCLR, priv->base + ICU_NSCLR);
> > > + break;
> > > + case ICU_IRQ_START ... ICU_IRQ_LAST:
> > > + /* Clear IRQ */
> > > tintirq_nr = hw_irq - ICU_IRQ_START;
> > > bit = BIT(tintirq_nr);
> > > if (!irqd_is_level_type(d))
> > > writel_relaxed(bit, priv->base + ICU_ISCLR);
> > > - } else {
> > > - writel_relaxed(ICU_NSCLR_NCLR, priv->base + ICU_NSCLR);
> > > + break;
> > > + case ICU_TINT_START ... ICU_TINT_LAST:
> > > + /* Clear TINT */
> > > + tintirq_nr = hw_irq - ICU_TINT_START;
> > > + bit = BIT(tintirq_nr);
> > > + if (!irqd_is_level_type(d))
> > > + writel_relaxed(bit, priv->base + priv->info->t_offs + ICU_TSCLR);
> > > + break;
> > > + default:
> > > + break;
> > > }
> > > }
> > >
> > > @@ -200,7 +211,7 @@ static void rzv2h_tint_irq_endisable(struct irq_data *d, bool enable)
> > > u32 tint_nr, tssel_n, k, tssr;
> > > u8 nr_tint;
> > >
> > > - if (hw_irq < ICU_TINT_START)
> > > + if (hw_irq < ICU_TINT_START || hw_irq > ICU_TINT_LAST)
> > > return;
> > >
> > > tint_nr = hw_irq - ICU_TINT_START; @@ -421,12 +432,22 @@
> > > static int rzv2h_icu_set_type(struct irq_data *d, unsigned int type)
> > > unsigned int hw_irq = irqd_to_hwirq(d);
> > > int ret;
> > >
> > > - if (hw_irq >= ICU_TINT_START)
> > > - ret = rzv2h_tint_set_type(d, type);
> > > - else if (hw_irq >= ICU_IRQ_START)
> > > - ret = rzv2h_irq_set_type(d, type);
> > > - else
> > > + switch (hw_irq) {
> > > + case 0:
> > > + /* NMI */
> > > ret = rzv2h_nmi_set_type(d, type);
> > > + break;
> > > + case ICU_IRQ_START ... ICU_IRQ_LAST:
> > > + /* IRQ */
> > > + ret = rzv2h_irq_set_type(d, type);
> > > + break;
> > > + case ICU_TINT_START ... ICU_TINT_LAST:
> > > + /* TINT */
> > > + ret = rzv2h_tint_set_type(d, type);
> > > + break;
> > > + default:
> > > + ret = -EINVAL;
> > > + }
> > >
> > > if (ret)
> > > return ret;
> > > @@ -507,11 +528,11 @@ static int rzv2h_icu_alloc(struct irq_domain *domain, unsigned int virq,
> unsigne
> > > * fwspec->param[0].
> > > * hwirq is embedded in bits 0-15.
> > > * TINT is embedded in bits 16-31.
> > > + * Check if bits 16-31 are set to identify TINT interrupts.
> > > */
> > > - if (hwirq >= ICU_TINT_START) {
> > > - tint = ICU_TINT_EXTRACT_GPIOINT(hwirq);
> > > + tint = ICU_TINT_EXTRACT_GPIOINT(hwirq);
> > > + if (tint) {
> >
> > Is tint == 0 does not happen?? I mean GPIOint == 0 is invalid??
> >
> For the P0_0 case, tint = 0 and hwirq == ICU_TINT_EXTRACT_HWIRQ(hwirq).
> In this situation, we do not need to enter the if condition.
You mean, no need to do the belowcheck if tint =0. But do only this check if tint > 0.
if (hwirq < ICU_TINT_START)
return -EINVAL;
Cheers,
Biju
Powered by blists - more mailing lists