linux-kernel - Re: [PATCH] HID: asus: Add check for cancelling fn_lock_sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <76269s1o-0465-895n-p0p0-1628sopn5324@xreary.bet>
Date: Wed, 4 Feb 2026 11:39:13 +0100 (CET)
From: Jiri Kosina <jikos@...nel.org>
To: Alan Stern <stern@...land.harvard.edu>
cc: Sahil Chandna <chandna.sahil@...il.com>, bentiss@...nel.org, 
    connorbelli2003@...il.com, linux-input@...r.kernel.org, 
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: asus: Add check for cancelling fn_lock_sync_work

On Mon, 2 Feb 2026, Alan Stern wrote:

> With no synchronization between the two routines, this patch cannot 
> possibly be correct.  There's nothing to prevent the CPU running 
> asus_input_configured() from executing the assignment to 
> drvdata->fn_lock before doing the INIT_WORK() (unless the INIT_WORK() 
> call itself contains some synchronization -- but obviously the code 
> shouldn't depend on that).

Ouch, you are of course right, that escaped my attention. Thanks a lot for 
catching this, Alan!

Now dropped from the queue.

-- 
Jiri Kosina
SUSE Labs