linux-kernel - Re: [PATCH v2] staging: greybus: gbphy: replace sprintf() with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYMiRAuE_GxwQMWt@stanley.mountain>
Date: Wed, 4 Feb 2026 13:41:08 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Neel Bullywon <neelb2403@...il.com>
Cc: Johan Hovold <johan@...nel.org>, Alex Elder <elder@...nel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	greybus-dev@...ts.linaro.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: greybus: gbphy: replace sprintf() with
 sysfs_emit()

It's best to wait a day between resends.

On Wed, Feb 04, 2026 at 05:13:42AM -0500, Neel Bullywon wrote:
> Replaced sprintf() with sysfs_emit() in the protocol_id_show() sysfs

I really hate to comment on this, because I famously get annoyed by
people who act like it's soooo important and we have one "reviewer" who
wants every sentence to be in imperative tense.  But past tense is kind
of ugly.  You did it right in the Subject on v2.  Use "Replace" instead
of "Replaced" here as well.

Btw, if someone provides you a commit message, then they're basically
obligated to allow it.

> attribute function. This code is safe, as replacing sprintf() with

s/as/as-is/?

> sysfs_emit() gets rid of calls to sprintf()

The line break is weird.

> as part of kernel hardening and sysfs_emit() is more appropriate in
> this context.
> 
> Signed-off-by: Neel Bullywon <neelb2403@...il.com>
> ---
> This was compile-tested only (no VM/hardware used)
> ---

You need to put a little note here to say what changed.

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

regards,
dan carpenter