linux-kernel - Re: [PATCH 1/2] sysfs: remove exports of sysfs_*change

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260205143511.GA1625457@google.com>
Date: Thu, 5 Feb 2026 14:35:11 +0000
From: Lee Jones <lee@...nel.org>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: rafael@...nel.org, dakr@...nel.org, driver-core@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] sysfs: remove exports of sysfs_*change_owner()

On Thu, 05 Feb 2026, Greg Kroah-Hartman wrote:

> Both sysfs_change_owner() and sysfs_file_change_owner() are exported to
> modules, but there are no in-kernel module users, so remove the exports
> so that crazy out-of-tree drivers don't get the impression that it is
> safe to call these functions at all.
> 
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Reported-by: Lee Jones <lee@...nel.org>
Reviewed-by: Lee Jones <lee@...nel.org>

:)

> ---
>  fs/sysfs/file.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c
> index 3825e780cc58..a8176c875f55 100644
> --- a/fs/sysfs/file.c
> +++ b/fs/sysfs/file.c
> @@ -689,7 +689,6 @@ int sysfs_file_change_owner(struct kobject *kobj, const char *name, kuid_t kuid,
>  
>  	return error;
>  }
> -EXPORT_SYMBOL_GPL(sysfs_file_change_owner);
>  
>  /**
>   *	sysfs_change_owner - change owner of the given object.
> @@ -736,7 +735,6 @@ int sysfs_change_owner(struct kobject *kobj, kuid_t kuid, kgid_t kgid)
>  
>  	return 0;
>  }
> -EXPORT_SYMBOL_GPL(sysfs_change_owner);
>  
>  /**
>   *	sysfs_emit - scnprintf equivalent, aware of PAGE_SIZE buffer.
> -- 
> 2.53.0
> 

-- 
Lee Jones [李琼斯]