linux-kernel - Re: [PATCH v5 1/3] dt-bindings: clk: tenstorrent: Add tenstorrent,atlantis-prcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEev2e8_4LSLNvHsiC4d7Rrd2GmjQ_5GRHU6b9-Ha69+yvn5cA@mail.gmail.com>
Date: Thu, 5 Feb 2026 08:31:50 -0600
From: Anirudh Srinivasan <asrinivasan@....tenstorrent.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Drew Fustini <dfustini@....tenstorrent.com>, Joel Stanley <jms@....tenstorrent.com>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>, 
	Philipp Zabel <p.zabel@...gutronix.de>, linux-riscv@...ts.infradead.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-clk@...r.kernel.org, joel@....id.au, fustini@...nel.org, mpe@...nel.org, 
	mpe@....tenstorrent.com, npiggin@....tenstorrent.com, agross@...nel.org, 
	agross@....tenstorrent.com, bmasney@...hat.com
Subject: Re: [PATCH v5 1/3] dt-bindings: clk: tenstorrent: Add tenstorrent,atlantis-prcm

Hi Krzysztof,

On Thu, Feb 5, 2026 at 3:23 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On Mon, Feb 02, 2026 at 01:46:49PM -0600, Anirudh Srinivasan wrote:
> > Document bindings for Tenstorrent Atlantis PRCM that manages clocks
> > and resets. This block is instantiated multiple times in the SoC.
> > This commit documents the clocks from the RCPU PRCM block.
> >
> > Signed-off-by: Anirudh Srinivasan <asrinivasan@....tenstorrent.com>
> > ---
> >  .../bindings/clock/tenstorrent,atlantis-prcm.yaml  |  54 +++++++++++
> >  MAINTAINERS                                        |   2 +
> >  .../dt-bindings/clock/tenstorrent,atlantis-prcm.h  | 103 +++++++++++++++++++++
> >  3 files changed, 159 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/tenstorrent,atlantis-prcm.yaml b/Documentation/devicetree/bindings/clock/tenstorrent,atlantis-prcm.yaml
> > new file mode 100644
> > index 000000000000..0f3e18f5ea1a
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/clock/tenstorrent,atlantis-prcm.yaml
>
> Still wrong name. Look how is your compatible called.

>
> > @@ -0,0 +1,54 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/clock/tenstorrent,atlantis-prcm.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Tenstorrent Atlantis PRCM (Power, Reset, Clock Management) Module
> > +
> > +maintainers:
> > +  - Anirudh Srinivasan <asrinivasan@....tenstorrent.com>
> > +
> > +description:
> > +  Multifunctional register block found in Tenstorrent Atlantis SoC whose main
> > +  function is to control clocks and resets. This block is instantiated multiple
> > +  times in the SoC, each block controls clock and resets for a different
> > +  subsystem. RCPU prcm serves low speed IO interfaces.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - tenstorrent,atlantis-prcm-rcpu
>
> Nothing in the changelog explained why 2 other compatibles were dropped.

I have mentioned in the changelog in the cover letter that these will
be added back when the driver for them is added (based on my
discussion with Conor).

>
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  clocks:
> > +    maxItems: 1
> > +
> > +  "#clock-cells":
> > +    const: 1
> > +    description:
> > +      See <dt-bindings/clock/tenstorrent,atlantis-prcm.h> for valid indices.
> > +
> > +  "#reset-cells":
> > +    const: 1
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - clocks
> > +  - "#clock-cells"
> > +  - "#reset-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    clock-controller@...00000 {
> > +      compatible = "tenstorrent,atlantis-prcm-rcpu";
> > +      reg = <0xa8000000 0x10000>;
> > +      clocks = <&osc_24m>;
> > +      #clock-cells = <1>;
> > +      #reset-cells = <1>;
> > +    };
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index dc731d37c8fe..0fc7bc6d0458 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -22534,8 +22534,10 @@ M:   Joel Stanley <jms@....tenstorrent.com>
> >  L:   linux-riscv@...ts.infradead.org
> >  S:   Maintained
> >  T:   git https://github.com/tenstorrent/linux.git
> > +F:   Documentation/devicetree/bindings/clock/tenstorrent,atlantis-prcm.yaml
> >  F:   Documentation/devicetree/bindings/riscv/tenstorrent.yaml
> >  F:   arch/riscv/boot/dts/tenstorrent/
> > +F:   include/dt-bindings/clock/tenstorrent,atlantis-prcm.h
> >
> >  RISC-V THEAD SoC SUPPORT
> >  M:   Drew Fustini <fustini@...nel.org>
> > diff --git a/include/dt-bindings/clock/tenstorrent,atlantis-prcm.h b/include/dt-bindings/clock/tenstorrent,atlantis-prcm.h
> > new file mode 100644
> > index 000000000000..3820781127c3
> > --- /dev/null
> > +++ b/include/dt-bindings/clock/tenstorrent,atlantis-prcm.h
>
> Still wrong name... Look at your compatible.
>
> Please read writing bindings doc in DT dir.

We will have multiple compatibles in the future (I dropped these in
this version and I have mentioned this in the changelog in the cover
letter) named "tenstorrent,atlantis-prcm-xyz". The bindings document
suggests picking a more generic name in this case, so isn't
"tenstorrent,atlantis-prcm" okay for that?

>
> Best regards,
> Krzysztof
>