linux-kernel - Re: [PATCH net-next v3] net: dsa: eliminate local type for tc policers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <49573634-3837-4f35-908a-44ccdadca1f8@redhat.com>
Date: Thu, 5 Feb 2026 15:44:19 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: David Yang <mmyangfl@...il.com>, netdev@...r.kernel.org
Cc: Vladimir Oltean <vladimir.oltean@....com>,
 Claudiu Manoil <claudiu.manoil@....com>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 UNGLinuxDriver@...rochip.com, Andrew Lunn <andrew@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Simon Horman <horms@...nel.org>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3] net: dsa: eliminate local type for tc
 policers

On 2/3/26 6:22 PM, David Yang wrote:
> diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h
> index 596ab9791e4d..a2b1b752958a 100644
> --- a/include/net/flow_offload.h
> +++ b/include/net/flow_offload.h
> @@ -275,7 +275,7 @@ struct flow_action_entry {
>  			u32			trunc_size;
>  			bool			truncate;
>  		} sample;
> -		struct {				/* FLOW_ACTION_POLICE */
> +		struct flow_action_police {		/* FLOW_ACTION_POLICE */
>  			u32			burst;
>  			u64			rate_bytes_ps;
>  			u64			peakrate_bytes_ps;

I find a bit unusual put the new type definition inside a wider struct.
I think it would be better move the struct flow_action_police standalone.

/P