linux-kernel - Re: [PATCH] media: iris: fix QCOM_MDT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1e026cc9-c89a-4c6f-8def-fc9eac5a00e8@oss.qualcomm.com>
Date: Thu, 5 Feb 2026 15:58:59 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Arnd Bergmann <arnd@...nel.org>,
        Vikash Garodia <vikash.garodia@....qualcomm.com>,
        Dikshita Agarwal <dikshita.agarwal@....qualcomm.com>,
        Bryan O'Donoghue <bod@...nel.org>,
        Mauro Carvalho Chehab
 <mchehab@...nel.org>,
        Rob Clark <robin.clark@....qualcomm.com>
Cc: Arnd Bergmann <arnd@...db.de>, Abhinav Kumar <abhinav.kumar@...ux.dev>,
        Hans Verkuil <hverkuil@...nel.org>,
        Stefan Schmidt <stefan.schmidt@...aro.org>,
        linux-media@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: iris: fix QCOM_MDT_LOADER dependency

On 2/5/26 3:56 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> When build-testined with CONFIG_QCOM_MDT_LOADER=m and VIDEO_QCOM_IRIS=y,
> the kernel fails to link:
> 
> x86_64-linux-ld: drivers/media/platform/qcom/iris/iris_firmware.o: in function `iris_fw_load':
> iris_firmware.c:(.text+0xb0): undefined reference to `qcom_mdt_get_size'
> iris_firmware.c:(.text+0xfd): undefined reference to `qcom_mdt_load'
> 
> The problem is the conditional 'select' statement. Change this to
> make the driver built-in here regardless of CONFIG_ARCH_QCOM.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>

I see that drm/msm (+Rob) does that too, but perhaps for a reason (old
I.MX platforms with Adreno)

Konrad