linux-kernel - Re: [PATCH] ASoC: fsl: imx-rpmsg: use snd_soc_find_dai_with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYS0drbxSEsr72vp@lizhi-Precision-Tower-5810>
Date: Thu, 5 Feb 2026 10:17:10 -0500
From: Frank Li <Frank.li@....com>
To: Ziyi Guo <n7l8m4@...orthwestern.edu>
Cc: Shengjiu Wang <shengjiu.wang@...il.com>, Xiubo Li <Xiubo.Lee@...il.com>,
	Fabio Estevam <festevam@...il.com>,
	Nicolin Chen <nicoleotsuka@...il.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>, Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>, kernel@...gutronix.de,
	linux-sound@...r.kernel.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: fsl: imx-rpmsg: use snd_soc_find_dai_with_mutex()
 in probe

On Thu, Feb 05, 2026 at 05:24:29AM +0000, Ziyi Guo wrote:
> imx_rpmsg_probe() calls snd_soc_find_dai() without holding client_mutex.
> However, snd_soc_find_dai() has lockdep_assert_held(&client_mutex)
> indicating callers must hold this lock, as the function iterates over the
> global component list.
>
> All other callers of snd_soc_find_dai() either hold client_mutex via the
> snd_soc_bind_card() path or use the snd_soc_find_dai_with_mutex() wrapper.
>
> Use snd_soc_find_dai_with_mutex() instead to fix the missing lock
> protection.
>
> Signed-off-by: Ziyi Guo <n7l8m4@...orthwestern.edu>
> ---
Reviewed-by: Frank Li <Frank.Li@....com>
>  sound/soc/fsl/imx-rpmsg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/fsl/imx-rpmsg.c b/sound/soc/fsl/imx-rpmsg.c
> index 53f04d1f3280..76a8e68c1b62 100644
> --- a/sound/soc/fsl/imx-rpmsg.c
> +++ b/sound/soc/fsl/imx-rpmsg.c
> @@ -145,7 +145,7 @@ static int imx_rpmsg_probe(struct platform_device *pdev)
>  	data->dai.ignore_pmdown_time = 1;
>
>  	data->dai.cpus->dai_name = pdev->dev.platform_data;
> -	cpu_dai = snd_soc_find_dai(data->dai.cpus);
> +	cpu_dai = snd_soc_find_dai_with_mutex(data->dai.cpus);
>  	if (!cpu_dai) {
>  		ret = -EPROBE_DEFER;
>  		goto fail;
> --
> 2.34.1
>