| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <9cb24a53-2077-4862-8872-db386a7e1742@oss.qualcomm.com>
Date: Thu, 5 Feb 2026 10:41:26 +0800
From: "Wei Zhang (Stone)" <wei.zhang@....qualcomm.com>
To: Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, weiden@....qualcomm.com,
Miaoqing Pan <miaoqing.pan@....qualcomm.com>
Subject: Re: [PATCH v9] arm64: dts: qcom: qcs8300-ride: enable WLAN on
qcs8300-ride
Hi ,
I’m writing to follow up on my patch which was sent on 1/22/2026.
It hasn’t received feedback yet, so I just wanted to check whether there
are any comments or changes you would like me to address.
Thanks a lot for your time and review.
Best regards,
Stone
On 1/22/2026 1:36 PM, Wei Zhang wrote:
> Enable WLAN on qcs8300-ride by adding a node for the PMU module
> of the WCN6855 and assigning its LDO power outputs to the existing
> WiFi module.
>
> On the qcs8300-ride platform, the corresponding firmware and BDF
> are QCA6698AQ instead of WCN6855, which have been added in the
> 20250211 release.
>
> Signed-off-by: Wei Zhang <wei.zhang@....qualcomm.com>
> ---
> This patch depends on:
> - PCIe
> https://lore.kernel.org/all/20251128104928.4070050-1-ziyue.zhang@oss.qualcomm.com/
>
> Changes in v9:
> - Refine and add precise descriptions of the WLAN voltage rails
> - Link to v8: https://lore.kernel.org/all/20260120070650.3192679-1-wei.zhang@oss.qualcomm.com/
>
> Changes in v8:
> - Reordered regulator nodes to maintain alphabetical consistency (Dmitry)
> - Link to v7: https://lore.kernel.org/all/20260119090758.2780678-1-wei.zhang@oss.qualcomm.com/
>
> Changes in v7:
> - Align regulator node names to match the existing naming style in the dts (Dmitry)
> - Link to v6: https://lore.kernel.org/all/20260119080125.2761623-1-wei.zhang@oss.qualcomm.com/
>
> Changes in v6:
> - Rebase patches
> - Remove unintended 'output-low' from wlan-en-state pinctrl (Konrad)
> - Link to v5: https://lore.kernel.org/all/20251113055148.2729943-1-wei.zhang@oss.qualcomm.com/
>
> Changes in v5:
> - Rebase patches
> - Flip the order of property-n and property-names (Konrad)
> - Flip the order of bias and output property (Konrad)
> - Link to v4: https://lore.kernel.org/all/20250325075331.1662306-1-quic_stonez@quicinc.com/
>
> Changes in v4:
> - Rename the symbol pcieport0 to pcie0_port0 (Konrad)
> - Adjust the property order in node pcie0_port0 (Konrad)
> - Add to the commit message mentioning FW and BDF used by QCS8300 (Dmitry)
> - Specify the calibration data using the correct variant (Dmitry)
> - Link to v3: https://lore.kernel.org/all/20250318093350.2682132-1-quic_stonez@quicinc.com/
>
> Changes in v3:
> - Complete the nodes property definitions according to DTS binding requirements (Bjorn)
> - Link to v2: https://lore.kernel.org/all/20250227065439.1407230-1-quic_stonez@quicinc.com/
>
> Changes in v2:
> - Rename the nodes name according to DTS coding style (Konrad & Krzysztof)
> - Provide regulator-min/max-microvolt to the regulators (Konrad)
> - Link to v1: https://lore.kernel.org/all/20250210062910.3618336-1-quic_stonez@quicinc.com/
> ---
> arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 130 ++++++++++++++++++++++
> 1 file changed, 130 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> index 68691f7b5f94..f8f021cfdf21 100644
> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts
> @@ -24,6 +24,50 @@ chosen {
> stdout-path = "serial0:115200n8";
> };
>
> + vreg_conn_1p05: regulator-conn-1p05 {
> + compatible = "regulator-fixed";
> + regulator-name = "vreg_conn_1p05";
> + regulator-min-microvolt = <1050000>;
> + regulator-max-microvolt = <1050000>;
> + vin-supply = <&vreg_conn_1p8>;
> + };
> +
> + vreg_conn_1p35: regulator-conn-1p35 {
> + compatible = "regulator-fixed";
> + regulator-name = "vreg_conn_1p35";
> + regulator-min-microvolt = <1350000>;
> + regulator-max-microvolt = <1350000>;
> + vin-supply = <&vreg_conn_1p8>;
> + };
> +
> + vreg_conn_1p8: regulator-conn-1p8 {
> + compatible = "regulator-fixed";
> + regulator-name = "vreg_conn_1p8";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + startup-delay-us = <4000>;
> + enable-active-high;
> + gpio = <&pmm8650au_1_gpios 4 GPIO_ACTIVE_HIGH>;
> + };
> +
> + vreg_conn_1p95: regulator-conn-1p95 {
> + compatible = "regulator-fixed";
> + regulator-name = "vreg_conn_1p95";
> + regulator-min-microvolt = <1950000>;
> + regulator-max-microvolt = <1950000>;
> + vin-supply = <&vreg_conn_1p8>;
> + };
> +
> + vreg_conn_pa: regulator-conn-pa {
> + compatible = "regulator-fixed";
> + regulator-name = "vreg_conn_pa";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + startup-delay-us = <4000>;
> + enable-active-high;
> + gpio = <&pmm8650au_1_gpios 6 GPIO_ACTIVE_HIGH>;
> + };
> +
> regulator-usb2-vbus {
> compatible = "regulator-fixed";
> regulator-name = "USB2_VBUS";
> @@ -33,6 +77,69 @@ regulator-usb2-vbus {
> enable-active-high;
> regulator-always-on;
> };
> +
> + wcn6855-pmu {
> + compatible = "qcom,wcn6855-pmu";
> +
> + pinctrl-0 = <&wlan_en_state>;
> + pinctrl-names = "default";
> +
> + vddio-supply = <&vreg_conn_pa>;
> + vddaon-supply = <&vreg_conn_1p8>;
> + vddpmu-supply = <&vreg_conn_pa>;
> + vddpmumx-supply = <&vreg_conn_1p8>;
> + vddpmucx-supply = <&vreg_conn_pa>;
> + /* WLAN rails: 1.05/1.35/1.95V (nominal 0.95/1.30/1.90V) */
> + vddrfa0p95-supply = <&vreg_conn_1p05>;
> + vddrfa1p3-supply = <&vreg_conn_1p35>;
> + vddrfa1p9-supply = <&vreg_conn_1p95>;
> + vddpcie1p3-supply = <&vreg_conn_1p35>;
> + vddpcie1p9-supply = <&vreg_conn_1p95>;
> +
> + wlan-enable-gpios = <&tlmm 54 GPIO_ACTIVE_HIGH>;
> +
> + regulators {
> + vreg_pmu_rfa_cmn: ldo0 {
> + regulator-name = "vreg_pmu_rfa_cmn";
> + };
> +
> + vreg_pmu_aon_0p59: ldo1 {
> + regulator-name = "vreg_pmu_aon_0p59";
> + };
> +
> + vreg_pmu_wlcx_0p8: ldo2 {
> + regulator-name = "vreg_pmu_wlcx_0p8";
> + };
> +
> + vreg_pmu_wlmx_0p85: ldo3 {
> + regulator-name = "vreg_pmu_wlmx_0p85";
> + };
> +
> + vreg_pmu_btcmx_0p85: ldo4 {
> + regulator-name = "vreg_pmu_btcmx_0p85";
> + };
> +
> + vreg_pmu_rfa_0p8: ldo5 {
> + regulator-name = "vreg_pmu_rfa_0p8";
> + };
> +
> + vreg_pmu_rfa_1p2: ldo6 {
> + regulator-name = "vreg_pmu_rfa_1p2";
> + };
> +
> + vreg_pmu_rfa_1p7: ldo7 {
> + regulator-name = "vreg_pmu_rfa_1p7";
> + };
> +
> + vreg_pmu_pcie_0p9: ldo8 {
> + regulator-name = "vreg_pmu_pcie_0p9";
> + };
> +
> + vreg_pmu_pcie_1p8: ldo9 {
> + regulator-name = "vreg_pmu_pcie_1p8";
> + };
> + };
> + };
> };
>
> &apps_rsc {
> @@ -327,6 +434,23 @@ &pcie0 {
> &pcieport0 {
> reset-gpios = <&tlmm 2 GPIO_ACTIVE_LOW>;
> wake-gpios = <&tlmm 0 GPIO_ACTIVE_HIGH>;
> +
> + wifi@0 {
> + compatible = "pci17cb,1103";
> + reg = <0x10000 0x0 0x0 0x0 0x0>;
> +
> + vddrfacmn-supply = <&vreg_pmu_rfa_cmn>;
> + vddaon-supply = <&vreg_pmu_aon_0p59>;
> + vddwlcx-supply = <&vreg_pmu_wlcx_0p8>;
> + vddwlmx-supply = <&vreg_pmu_wlmx_0p85>;
> + vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>;
> + vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>;
> + vddrfa1p8-supply = <&vreg_pmu_rfa_1p7>;
> + vddpcie0p9-supply = <&vreg_pmu_pcie_0p9>;
> + vddpcie1p8-supply = <&vreg_pmu_pcie_1p8>;
> +
> + qcom,calibration-variant = "QC_QCS8300_Ride";
> + };
> };
>
> &pcie0_phy {
> @@ -461,6 +585,12 @@ perst-pins {
> bias-pull-down;
> };
> };
> +
> + wlan_en_state: wlan-en-state {
> + pins = "gpio54";
> + function = "gpio";
> + bias-pull-up;
> + };
> };
>
> &uart7 {
>
> base-commit: cf38b2340c0e60ef695b7137440a4d187ed49c88
> prerequisite-patch-id: 0e8aad7b8514142fb33c17829386f17c3a55127a
> prerequisite-patch-id: e641f09d4139ac77c34757bd08af2db746de3963
> prerequisite-patch-id: 4d16e87cf6213d6e25b2c40e2753d4e629778d53
> prerequisite-patch-id: 40187dae2c9518a10866104b9fcd5a481ac67d51
> prerequisite-patch-id: dd3bdf2aebda74f3603aff24a2c9aaa7f4fd6763
Powered by blists - more mailing lists