linux-kernel - Re: [PATCH v7 4/8] iio: adc: ad4030: Use BIT macro to improve code readability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYTNGKPPfFRoEuW3@smile.fi.intel.com>
Date: Thu, 5 Feb 2026 19:02:16 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Marcelo Schmitt <marcelo.schmitt@...log.com>
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	jic23@...nel.org, michael.hennerich@...log.com, nuno.sa@...log.com,
	eblanc@...libre.com, dlechner@...libre.com, andy@...nel.org,
	robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	corbet@....net, marcelo.schmitt1@...il.com,
	Andy Shevchenko <andy.shevchenko@...il.com>
Subject: Re: [PATCH v7 4/8] iio: adc: ad4030: Use BIT macro to improve code
 readability

On Thu, Feb 05, 2026 at 01:48:19PM -0300, Marcelo Schmitt wrote:
> Use BIT macro to make the list of average modes more readable.

Acked-by: Andy Shevchenko <andy.shevchenko@...il.com>

...

> +	BIT(0),

Maybe a comment here (yes, I read the top comment,
this is just for the sake of preventing regrouping
in the future).

	BIT(0),					/* No sampling average */

but again, no need to resend for this tiny thing.

> +	BIT(1), BIT(2), BIT(3), BIT(4),
> +	BIT(5), BIT(6), BIT(7), BIT(8),
> +	BIT(9), BIT(10), BIT(11), BIT(12),
> +	BIT(13), BIT(14), BIT(15), BIT(16),

-- 
With Best Regards,
Andy Shevchenko