linux-kernel - Re: [PATCH v7 5/8] iio: adc: ad4030: Add SPI offload support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYTPPNE-GxkeokjV@smile.fi.intel.com>
Date: Thu, 5 Feb 2026 19:11:24 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Marcelo Schmitt <marcelo.schmitt@...log.com>
Cc: linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	jic23@...nel.org, michael.hennerich@...log.com, nuno.sa@...log.com,
	eblanc@...libre.com, dlechner@...libre.com, andy@...nel.org,
	robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	corbet@....net, marcelo.schmitt1@...il.com,
	Trevor Gamblin <tgamblin@...libre.com>,
	Axel Haslam <ahaslam@...libre.com>
Subject: Re: [PATCH v7 5/8] iio: adc: ad4030: Add SPI offload support

On Thu, Feb 05, 2026 at 07:08:48PM +0200, Andy Shevchenko wrote:
> On Thu, Feb 05, 2026 at 01:48:40PM -0300, Marcelo Schmitt wrote:

...

> > +	cnv_wf.period_length_ns = DIV_ROUND_CLOSEST(NSEC_PER_SEC, cnv_rate_hz);

> > +	offload_period_ns = DIV_ROUND_CLOSEST(NSEC_PER_SEC, freq_hz);

^^^ for the context to the below remark.

...

> > +	config->periodic.frequency_hz = DIV_ROUND_UP_ULL(NSEC_PER_SEC,
> > +							 offload_period_ns);
> 
> The point of having _ULL version here is...?

And for the consistency with the above this should be HZ_PER_GHZ.

-- 
With Best Regards,
Andy Shevchenko