linux-kernel - Re: [RFC PATCH v2 08/12] spi: cadence-quadspi: read 'has-dqs' DT property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h5rvgkjs.fsf@bootlin.com>
Date: Thu, 05 Feb 2026 18:35:51 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Santhosh Kumar K <s-k6@...com>
Cc: <broonie@...nel.org>,  <robh@...nel.org>,  <krzk+dt@...nel.org>,
  <conor+dt@...nel.org>,  <richard@....at>,  <vigneshr@...com>,
  <tudor.ambarus@...aro.org>,  <pratyush@...nel.org>,  <mwalle@...nel.org>,
  <linux-spi@...r.kernel.org>,  <devicetree@...r.kernel.org>,
  <linux-kernel@...r.kernel.org>,  <linux-mtd@...ts.infradead.org>,
  <praneeth@...com>,  <u-kumar1@...com>,  <p-mantena@...com>,
  <a-dutta@...com>
Subject: Re: [RFC PATCH v2 08/12] spi: cadence-quadspi: read 'has-dqs' DT
 property

On 13/01/2026 at 19:46:13 +0530, Santhosh Kumar K <s-k6@...com> wrote:

> Add a boolean field to struct cqspi_flash_pdata to store whether the
> attached flash device supports DQS (Data Strobe) mode. Read this from
> the 'spi-has-dqs' device tree property during flash node parsing.
>
> This is preparatory infrastructure for PHY tuning support. The field
> will be used by subsequent patches to configure read data capture timing
> with DQS enabled for improved margins in high-speed operations.
>
> Signed-off-by: Santhosh Kumar K <s-k6@...com>

As mentioned in my answer to the cover letter, I am not too much in
favour of this property because this is something that is somewhat
related to the chip ID, thus discoverable. I drafted something to get
rid of this property already, I will share it for opening the
discussion.

However, for now I am closing my eyes on the fact that the DQS pin might
not be wired to the controller. In this case we will need some kind of
"dqs-not-wired" DT property, that's true, but also easily manageable at
the core level later, when/if the need arises.

Thanks,
Miquèl