linux-kernel - Re: [PATCH v2] audit: Avoid excessive dput/dget in audit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAGudoHFz1QZdYTp=PbAF+v-3-EZhwL0PQz+Zv0nNTG0WCSAdAw@mail.gmail.com>
Date: Thu, 5 Feb 2026 18:53:34 +0100
From: Mateusz Guzik <mjguzik@...il.com>
To: Al Viro <viro@...iv.linux.org.uk>
Cc: Waiman Long <llong@...hat.com>, Paul Moore <paul@...l-moore.com>, 
	Eric Paris <eparis@...hat.com>, Christian Brauner <brauner@...nel.org>, linux-kernel@...r.kernel.org, 
	audit@...r.kernel.org, Richard Guy Briggs <rgb@...hat.com>, 
	Ricardo Robaina <rrobaina@...hat.com>
Subject: Re: [PATCH v2] audit: Avoid excessive dput/dget in audit_context
 setup and reset paths

On Thu, Feb 5, 2026 at 6:20 AM Al Viro <viro@...iv.linux.org.uk> wrote:
> Mateusz: *is* there a measurable effect?  Because if there isn't, I'm
> very tempted to simply revert that thing.  "Churn of adding fs_struct.h
> as needed" is not the problem - try "exposing the object internals to
> far larger subset of the kernel".  We had interesting bugs with weird
> shit deciding to poke in there, locking and refcounting be damned.

This one I did not bother benchmarking as it is an obvious change --
read a var directly instead of going through a func call.

If this is causing trouble then it definitely needs to be reverted,
but any woes only speak to the mess in the header files.