linux-kernel - Re: [PATCH v3 4/9] iio: amplifiers: ad8366: drop reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <rp62czb4n3ag64cgluwsodubnqxecod3cuu2agyedqed2vwi3j@qs3e7xhf5ksk>
Date: Thu, 5 Feb 2026 18:12:23 +0000
From: Rodrigo Alencar <455.rodrigo.alencar@...il.com>
To: Andy Shevchenko <andriy.shevchenko@...el.com>, 
	rodrigo.alencar@...log.com
Cc: linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org, 
	devicetree@...r.kernel.org, Michael Hennerich <Michael.Hennerich@...log.com>, 
	Lars-Peter Clausen <lars@...afoo.de>, Jonathan Cameron <jic23@...nel.org>, 
	David Lechner <dlechner@...libre.com>, Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH v3 4/9] iio: amplifiers: ad8366: drop reset_gpio from
 private struct

On 26/02/04 03:55AM, Andy Shevchenko wrote:
> On Tue, Feb 03, 2026 at 11:24:10AM +0000, Rodrigo Alencar via B4 Relay wrote:
> 
> > Remove reset_gpio from the device state struct and turn it
> > into a local variable, as it is not being used anywhere else.
> 
> Why not switching to reset-gpio driver to begin with?

No particular reason, consuming it as gpio was already there!
Is this a suggestion/recommendation or a mandatory thing for
now on?

looked over some examples, some are not updating dt-bindings with resets,
others don't have Kconfig requiring POWER_RESET or POWER_RESET_GPIO config.
Those things are necessary, right?
 
-- 
Kind regards,

Rodrigo Alencar