| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <aYTjRfN1NwYbUsAp@skinsburskii.localdomain>
Date: Thu, 5 Feb 2026 10:36:53 -0800
From: Stanislav Kinsburskii <skinsburskii@...ux.microsoft.com>
To: Anirudh Rayabharam <anirudh@...rudhrb.com>
Cc: kys@...rosoft.com, haiyangz@...rosoft.com, wei.liu@...nel.org,
decui@...rosoft.com, longli@...rosoft.com,
linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/4] mshv: Handle insufficient root memory hypervisor
statuses
On Thu, Feb 05, 2026 at 11:37:49PM +0530, Anirudh Rayabharam wrote:
> On Mon, Feb 02, 2026 at 05:59:14PM +0000, Stanislav Kinsburskii wrote:
> > When creating guest partition objects, the hypervisor may fail to
> > allocate root partition pages and return an insufficient memory status.
> > In this case, deposit memory using the root partition ID instead.
> >
> > Note: This error should never occur in a guest of L1VH partition context.
> >
> > Signed-off-by: Stanislav Kinsburskii <skinsburskii@...ux.microsoft.com>
> > ---
> > drivers/hv/hv_common.c | 2 +
> > drivers/hv/hv_proc.c | 14 ++++++++++
> > include/hyperv/hvgdk_mini.h | 58 ++++++++++++++++++++++---------------------
> > 3 files changed, 46 insertions(+), 28 deletions(-)
> >
> > diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c
> > index c7f63c9de503..cab0d1733607 100644
> > --- a/drivers/hv/hv_common.c
> > +++ b/drivers/hv/hv_common.c
> > @@ -792,6 +792,8 @@ static const struct hv_status_info hv_status_infos[] = {
> > _STATUS_INFO(HV_STATUS_PROPERTY_VALUE_OUT_OF_RANGE, -EIO),
> > _STATUS_INFO(HV_STATUS_INSUFFICIENT_MEMORY, -ENOMEM),
> > _STATUS_INFO(HV_STATUS_INSUFFICIENT_CONTIGUOUS_MEMORY, -ENOMEM),
> > + _STATUS_INFO(HV_STATUS_INSUFFICIENT_ROOT_MEMORY, -ENOMEM),
> > + _STATUS_INFO(HV_STATUS_INSUFFICIENT_CONTIGUOUS_ROOT_MEMORY, -ENOMEM),
> > _STATUS_INFO(HV_STATUS_INVALID_PARTITION_ID, -EINVAL),
> > _STATUS_INFO(HV_STATUS_INVALID_VP_INDEX, -EINVAL),
> > _STATUS_INFO(HV_STATUS_NOT_FOUND, -EIO),
> > diff --git a/drivers/hv/hv_proc.c b/drivers/hv/hv_proc.c
> > index dfa27be66ff7..935129e0b39d 100644
> > --- a/drivers/hv/hv_proc.c
> > +++ b/drivers/hv/hv_proc.c
> > @@ -122,6 +122,18 @@ int hv_deposit_memory_node(int node, u64 partition_id,
> > case HV_STATUS_INSUFFICIENT_CONTIGUOUS_MEMORY:
> > num_pages = HV_MAX_CONTIGUOUS_ALLOCATION_PAGES;
> > break;
> > +
> > + case HV_STATUS_INSUFFICIENT_CONTIGUOUS_ROOT_MEMORY:
> > + num_pages = HV_MAX_CONTIGUOUS_ALLOCATION_PAGES;
> > + fallthrough;
> > + case HV_STATUS_INSUFFICIENT_ROOT_MEMORY:
>
> Is num_pages uninitialized when we reach this case directly?
>
It actually does not. I'll fix it.
Thanks,
Stanislav
> Thanks,
> Anirudh.
>
> > + if (!hv_root_partition()) {
> > + hv_status_err(hv_status, "Unexpected root memory deposit\n");
> > + return -ENOMEM;
> > + }
> > + partition_id = HV_PARTITION_ID_SELF;
> > + break;
> > +
> > default:
> > hv_status_err(hv_status, "Unexpected!\n");
> > return -ENOMEM;
> > @@ -135,6 +147,8 @@ bool hv_result_needs_memory(u64 status)
> > switch (hv_result(status)) {
> > case HV_STATUS_INSUFFICIENT_MEMORY:
> > case HV_STATUS_INSUFFICIENT_CONTIGUOUS_MEMORY:
> > + case HV_STATUS_INSUFFICIENT_ROOT_MEMORY:
> > + case HV_STATUS_INSUFFICIENT_CONTIGUOUS_ROOT_MEMORY:
> > return true;
> > }
> > return false;
> > diff --git a/include/hyperv/hvgdk_mini.h b/include/hyperv/hvgdk_mini.h
> > index 70f22ef44948..5b74a857ef43 100644
> > --- a/include/hyperv/hvgdk_mini.h
> > +++ b/include/hyperv/hvgdk_mini.h
> > @@ -14,34 +14,36 @@ struct hv_u128 {
> > } __packed;
> >
> > /* NOTE: when adding below, update hv_result_to_string() */
> > -#define HV_STATUS_SUCCESS 0x0
> > -#define HV_STATUS_INVALID_HYPERCALL_CODE 0x2
> > -#define HV_STATUS_INVALID_HYPERCALL_INPUT 0x3
> > -#define HV_STATUS_INVALID_ALIGNMENT 0x4
> > -#define HV_STATUS_INVALID_PARAMETER 0x5
> > -#define HV_STATUS_ACCESS_DENIED 0x6
> > -#define HV_STATUS_INVALID_PARTITION_STATE 0x7
> > -#define HV_STATUS_OPERATION_DENIED 0x8
> > -#define HV_STATUS_UNKNOWN_PROPERTY 0x9
> > -#define HV_STATUS_PROPERTY_VALUE_OUT_OF_RANGE 0xA
> > -#define HV_STATUS_INSUFFICIENT_MEMORY 0xB
> > -#define HV_STATUS_INVALID_PARTITION_ID 0xD
> > -#define HV_STATUS_INVALID_VP_INDEX 0xE
> > -#define HV_STATUS_NOT_FOUND 0x10
> > -#define HV_STATUS_INVALID_PORT_ID 0x11
> > -#define HV_STATUS_INVALID_CONNECTION_ID 0x12
> > -#define HV_STATUS_INSUFFICIENT_BUFFERS 0x13
> > -#define HV_STATUS_NOT_ACKNOWLEDGED 0x14
> > -#define HV_STATUS_INVALID_VP_STATE 0x15
> > -#define HV_STATUS_NO_RESOURCES 0x1D
> > -#define HV_STATUS_PROCESSOR_FEATURE_NOT_SUPPORTED 0x20
> > -#define HV_STATUS_INVALID_LP_INDEX 0x41
> > -#define HV_STATUS_INVALID_REGISTER_VALUE 0x50
> > -#define HV_STATUS_OPERATION_FAILED 0x71
> > -#define HV_STATUS_INSUFFICIENT_CONTIGUOUS_MEMORY 0x75
> > -#define HV_STATUS_TIME_OUT 0x78
> > -#define HV_STATUS_CALL_PENDING 0x79
> > -#define HV_STATUS_VTL_ALREADY_ENABLED 0x86
> > +#define HV_STATUS_SUCCESS 0x0
> > +#define HV_STATUS_INVALID_HYPERCALL_CODE 0x2
> > +#define HV_STATUS_INVALID_HYPERCALL_INPUT 0x3
> > +#define HV_STATUS_INVALID_ALIGNMENT 0x4
> > +#define HV_STATUS_INVALID_PARAMETER 0x5
> > +#define HV_STATUS_ACCESS_DENIED 0x6
> > +#define HV_STATUS_INVALID_PARTITION_STATE 0x7
> > +#define HV_STATUS_OPERATION_DENIED 0x8
> > +#define HV_STATUS_UNKNOWN_PROPERTY 0x9
> > +#define HV_STATUS_PROPERTY_VALUE_OUT_OF_RANGE 0xA
> > +#define HV_STATUS_INSUFFICIENT_MEMORY 0xB
> > +#define HV_STATUS_INVALID_PARTITION_ID 0xD
> > +#define HV_STATUS_INVALID_VP_INDEX 0xE
> > +#define HV_STATUS_NOT_FOUND 0x10
> > +#define HV_STATUS_INVALID_PORT_ID 0x11
> > +#define HV_STATUS_INVALID_CONNECTION_ID 0x12
> > +#define HV_STATUS_INSUFFICIENT_BUFFERS 0x13
> > +#define HV_STATUS_NOT_ACKNOWLEDGED 0x14
> > +#define HV_STATUS_INVALID_VP_STATE 0x15
> > +#define HV_STATUS_NO_RESOURCES 0x1D
> > +#define HV_STATUS_PROCESSOR_FEATURE_NOT_SUPPORTED 0x20
> > +#define HV_STATUS_INVALID_LP_INDEX 0x41
> > +#define HV_STATUS_INVALID_REGISTER_VALUE 0x50
> > +#define HV_STATUS_OPERATION_FAILED 0x71
> > +#define HV_STATUS_INSUFFICIENT_ROOT_MEMORY 0x73
> > +#define HV_STATUS_INSUFFICIENT_CONTIGUOUS_MEMORY 0x75
> > +#define HV_STATUS_TIME_OUT 0x78
> > +#define HV_STATUS_CALL_PENDING 0x79
> > +#define HV_STATUS_INSUFFICIENT_CONTIGUOUS_ROOT_MEMORY 0x83
> > +#define HV_STATUS_VTL_ALREADY_ENABLED 0x86
> >
> > /*
> > * The Hyper-V TimeRefCount register and the TSC
> >
> >
Powered by blists - more mailing lists