linux-kernel - Re: [PATCH v5 2/3] reset: tenstorrent: Add reset controller for Atlantis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cb18f760-500b-4417-b706-cdc7448441a4@kernel.org>
Date: Thu, 5 Feb 2026 19:47:42 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Anirudh Srinivasan <asrinivasan@....tenstorrent.com>
Cc: Drew Fustini <dfustini@....tenstorrent.com>,
 Joel Stanley <jms@....tenstorrent.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Michael Turquette <mturquette@...libre.com>,
 Stephen Boyd <sboyd@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>,
 linux-riscv@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org, joel@....id.au,
 fustini@...nel.org, mpe@...nel.org, mpe@....tenstorrent.com,
 npiggin@....tenstorrent.com, agross@...nel.org, agross@....tenstorrent.com,
 bmasney@...hat.com
Subject: Re: [PATCH v5 2/3] reset: tenstorrent: Add reset controller for
 Atlantis

On 05/02/2026 15:18, Anirudh Srinivasan wrote:
> Hello Krzysztof,
> 
> On Thu, Feb 5, 2026 at 3:27 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>>
>> On Mon, Feb 02, 2026 at 01:46:50PM -0600, Anirudh Srinivasan wrote:
>>> diff --git a/include/soc/tenstorrent/atlantis-prcm.h b/include/soc/tenstorrent/atlantis-prcm.h
>>> new file mode 100644
>>> index 000000000000..841516cbefd9
>>> --- /dev/null
>>> +++ b/include/soc/tenstorrent/atlantis-prcm.h
>>> @@ -0,0 +1,31 @@
>>> +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
>>> +/*
>>> + * Shared definitions for Atlantis PRCM Clock and Reset Drivers
>>> + *
>>> + * Copyright (c) 2026 Tenstorrent
>>> + */
>>> +#ifndef __SOC_ATLANTIS_PRCM_H__
>>> +#define __SOC_ATLANTIS_PRCM_H__
>>> +
>>> +#include <linux/bits.h>
>>> +#include <linux/types.h>
>>> +
>>> +struct atlantis_prcm_adev {
>>> +     struct auxiliary_device adev;
>>> +     struct regmap *regmap;
>>> +};
>>
>> Drop, there is no driver-wide user of this.
> 
>>
>>> +
>>> +static inline struct atlantis_prcm_adev *
>>> +to_atlantis_prcm_adev(struct auxiliary_device *adev)
>>
>> Same here.
>>
>> Do not add symbols to headers which nothing uses. These are private to
>> the driver so they must stay ONLY in the driver.
> 
> The definitions in these files are shared between the clock and reset
> driver (which are in drivers/clk/tenstorrent/ and drivers/reset/),
> hence they have been put here.


Ah, but then I wonder why your clock driver needs to access reset driver
structures. Or vice versa. You are only expected to get regmap from the
parent, no?


Best regards,
Krzysztof