linux-kernel - [PATCH] sched/fair: Group pick-tree-entity helper functions together

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20260205191215.79783-1-frn1furkan10@gmail.com>
Date: Thu,  5 Feb 2026 22:12:15 +0300
From: Furkan Caliskan <frn1furkan10@...il.com>
To: mingo@...hat.com,
	peterz@...radead.org
Cc: linux-kernel@...r.kernel.org,
	frn1furkan10@...il.com
Subject: [PATCH] sched/fair: Group pick-tree-entity helper functions together

__pick_root_entity(), __pick_first_entity() and __pick_last_entity() functions
are closely related. Grouping them together improves readability and code
symmetry. There is no functional change.

Signed-off-by: Furkan Caliskan <frn1furkan10@...il.com>
---
 kernel/sched/fair.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index c16b5fd71b..8ab245f0a7 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -891,6 +891,16 @@ struct sched_entity *__pick_first_entity(struct cfs_rq *cfs_rq)
 	return __node_2_se(left);
 }
 
+struct sched_entity *__pick_last_entity(struct cfs_rq *cfs_rq)
+{
+	struct rb_node *last = rb_last(&cfs_rq->tasks_timeline.rb_root);
+
+	if (!last)
+		return NULL;
+
+	return __node_2_se(last);
+}
+
 /*
  * Set the vruntime up to which an entity can run before looking
  * for another entity to pick.
@@ -1027,16 +1037,6 @@ static struct sched_entity *pick_eevdf(struct cfs_rq *cfs_rq)
 	return __pick_eevdf(cfs_rq, true);
 }
 
-struct sched_entity *__pick_last_entity(struct cfs_rq *cfs_rq)
-{
-	struct rb_node *last = rb_last(&cfs_rq->tasks_timeline.rb_root);
-
-	if (!last)
-		return NULL;
-
-	return __node_2_se(last);
-}
-
 /**************************************************************
  * Scheduling class statistics methods:
  */
-- 
2.34.1