| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20260205191315.8936-1-zeeshanahmad022019@gmail.com>
Date: Fri, 6 Feb 2026 00:13:14 +0500
From: Zeeshan Ahmad <zeeshanahmad022019@...il.com>
To: Parthiban Veerasooran <parthiban.veerasooran@...rochip.com>,
Christian Gromm <christian.gromm@...rochip.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-staging@...ts.linux.dev,
linux-kernel@...r.kernel.org,
Zeeshan Ahmad <zeeshanahmad022019@...il.com>
Subject: [PATCH] staging: most: dim2: convert pr_info/err/warn to dev_info/err/warn
The dim2 driver currently uses generic pr_* logging macros. Hardware
drivers should use the device-specific dev_* logging macros to provide
better context in the system logs, especially in systems with multiple
controller instances.
This patch converts all applicable logging calls in dim2.c to use the
proper device-specific APIs.
Signed-off-by: Zeeshan Ahmad <zeeshanahmad022019@...il.com>
---
drivers/staging/most/dim2/dim2.c | 44 ++++++++++++++++----------------
1 file changed, 22 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c
index dad2abe6c0c9..e6d99d9009b5 100644
--- a/drivers/staging/most/dim2/dim2.c
+++ b/drivers/staging/most/dim2/dim2.c
@@ -244,9 +244,9 @@ static void retrieve_netinfo(struct dim2_hdm *dev, struct mbo *mbo)
{
u8 *data = mbo->virt_address;
- pr_info("Node Address: 0x%03x\n", (u16)data[16] << 8 | data[17]);
+ dev_info(&dev->dev, "Node Address: 0x%03x\n", (u16)data[16] << 8 | data[17]);
dev->link_state = data[18];
- pr_info("NIState: %d\n", dev->link_state);
+ dev_info(&dev->dev, "NIState: %d\n", dev->link_state);
memcpy(dev->mac_addrs, data + 19, 6);
dev->deliver_netinfo++;
wake_up_interruptible(&dev->netinfo_waitq);
@@ -470,13 +470,13 @@ static int configure_channel(struct most_interface *most_iface, int ch_idx,
case MOST_CH_CONTROL:
new_size = dim_norm_ctrl_async_buffer_size(buf_size);
if (new_size == 0) {
- pr_err("%s: too small buffer size\n", hdm_ch->name);
+ dev_err(&dev->dev, "%s: too small buffer size\n", hdm_ch->name);
return -EINVAL;
}
ccfg->buffer_size = new_size;
if (new_size != buf_size)
- pr_warn("%s: fixed buffer size (%d -> %d)\n",
- hdm_ch->name, buf_size, new_size);
+ dev_warn(&dev->dev, "%s: fixed buffer size (%d -> %d)\n",
+ hdm_ch->name, buf_size, new_size);
spin_lock_irqsave(&dim_lock, flags);
hal_ret = dim_init_control(&hdm_ch->ch, is_tx, ch_addr,
is_tx ? new_size * 2 : new_size);
@@ -484,13 +484,13 @@ static int configure_channel(struct most_interface *most_iface, int ch_idx,
case MOST_CH_ASYNC:
new_size = dim_norm_ctrl_async_buffer_size(buf_size);
if (new_size == 0) {
- pr_err("%s: too small buffer size\n", hdm_ch->name);
+ dev_err(&dev->dev, "%s: too small buffer size\n", hdm_ch->name);
return -EINVAL;
}
ccfg->buffer_size = new_size;
if (new_size != buf_size)
- pr_warn("%s: fixed buffer size (%d -> %d)\n",
- hdm_ch->name, buf_size, new_size);
+ dev_warn(&dev->dev, "%s: fixed buffer size (%d -> %d)\n",
+ hdm_ch->name, buf_size, new_size);
spin_lock_irqsave(&dim_lock, flags);
hal_ret = dim_init_async(&hdm_ch->ch, is_tx, ch_addr,
is_tx ? new_size * 2 : new_size);
@@ -498,41 +498,41 @@ static int configure_channel(struct most_interface *most_iface, int ch_idx,
case MOST_CH_ISOC:
new_size = dim_norm_isoc_buffer_size(buf_size, sub_size);
if (new_size == 0) {
- pr_err("%s: invalid sub-buffer size or too small buffer size\n",
- hdm_ch->name);
+ dev_err(&dev->dev, "%s: invalid sub-buffer size or too small buffer size\n",
+ hdm_ch->name);
return -EINVAL;
}
ccfg->buffer_size = new_size;
if (new_size != buf_size)
- pr_warn("%s: fixed buffer size (%d -> %d)\n",
- hdm_ch->name, buf_size, new_size);
+ dev_warn(&dev->dev, "%s: fixed buffer size (%d -> %d)\n",
+ hdm_ch->name, buf_size, new_size);
spin_lock_irqsave(&dim_lock, flags);
hal_ret = dim_init_isoc(&hdm_ch->ch, is_tx, ch_addr, sub_size);
break;
case MOST_CH_SYNC:
new_size = dim_norm_sync_buffer_size(buf_size, sub_size);
if (new_size == 0) {
- pr_err("%s: invalid sub-buffer size or too small buffer size\n",
- hdm_ch->name);
+ dev_err(&dev->dev, "%s: invalid sub-buffer size or too small buffer size\n",
+ hdm_ch->name);
return -EINVAL;
}
ccfg->buffer_size = new_size;
if (new_size != buf_size)
- pr_warn("%s: fixed buffer size (%d -> %d)\n",
- hdm_ch->name, buf_size, new_size);
+ dev_warn(&dev->dev, "%s: fixed buffer size (%d -> %d)\n",
+ hdm_ch->name, buf_size, new_size);
spin_lock_irqsave(&dim_lock, flags);
hal_ret = dim_init_sync(&hdm_ch->ch, is_tx, ch_addr, sub_size);
break;
default:
- pr_err("%s: configure failed, bad channel type: %d\n",
- hdm_ch->name, ccfg->data_type);
+ dev_err(&dev->dev, "%s: configure failed, bad channel type: %d\n",
+ hdm_ch->name, ccfg->data_type);
return -EINVAL;
}
if (hal_ret != DIM_NO_ERROR) {
spin_unlock_irqrestore(&dim_lock, flags);
- pr_err("%s: configure failed (%d), type: %d, is_tx: %d\n",
- hdm_ch->name, hal_ret, ccfg->data_type, (int)is_tx);
+ dev_err(&dev->dev, "%s: configure failed (%d), type: %d, is_tx: %d\n",
+ hdm_ch->name, hal_ret, ccfg->data_type, (int)is_tx);
return -ENODEV;
}
@@ -606,7 +606,7 @@ static void request_netinfo(struct most_interface *most_iface, int ch_idx,
return;
if (dev->atx_idx < 0) {
- pr_err("Async Tx Not initialized\n");
+ dev_err(&dev->dev, "Async Tx Not initialized\n");
return;
}
@@ -655,7 +655,7 @@ static int poison_channel(struct most_interface *most_iface, int ch_idx)
dev->atx_idx = -1;
spin_unlock_irqrestore(&dim_lock, flags);
if (hal_ret != DIM_NO_ERROR) {
- pr_err("HAL Failed to close channel %s\n", hdm_ch->name);
+ dev_err(&dev->dev, "HAL Failed to close channel %s\n", hdm_ch->name);
ret = -EFAULT;
}
--
2.43.0
Powered by blists - more mailing lists