[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20260205200340.0f343ceb@jic23-huawei>
Date: Thu, 5 Feb 2026 20:03:40 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: Cosmin-Gabriel Tanislav <cosmin-gabriel.tanislav.xa@...esas.com>, Nuno
Sá <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: ABI: fix current_trigger description
On Wed, 4 Feb 2026 13:55:33 -0600
David Lechner <dlechner@...libre.com> wrote:
> On 2/4/26 1:50 PM, Cosmin-Gabriel Tanislav wrote:
> >> From: David Lechner <dlechner@...libre.com>
> >> Sent: Wednesday, February 4, 2026 9:44 PM
> >>
> >> On 2/4/26 12:02 PM, Cosmin Tanislav wrote:
> >>> Triggers exist under /sys/bus/iio/devices/, not under /sys/class/iio.
> >>> /sys/class/iio does not even exist. Use the current path.
> >>>
> >>> Signed-off-by: Cosmin Tanislav <cosmin-gabriel.tanislav.xa@...esas.com>
> >>> ---
> >>> Documentation/ABI/testing/sysfs-bus-iio | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> >>> index 5f87dcee78f7..4fc9f6bd4281 100644
> >>> --- a/Documentation/ABI/testing/sysfs-bus-iio
> >>> +++ b/Documentation/ABI/testing/sysfs-bus-iio
> >>> @@ -1428,7 +1428,7 @@ KernelVersion: 2.6.35
> >>> Contact: linux-iio@...r.kernel.org
> >>> Description:
> >>> The name of the trigger source being used, as per string given
> >>> - in /sys/class/iio/triggerY/name.
> >>> + in /sys/bus/iio/devices/triggerY/name.
> >>
> >> While we are fixing this, the docs refer to it as triggerX rather than
> >> triggerY.
> >>
> >
> > While I do agree that triggerX would match the definition inside
> > Documentation/ABI/testing/sysfs-bus-iio-trigger-sysfs, I think
> > triggerY is the correct name here, because iio:deviceX is used
> > right above. If we were to use triggerX, it would leave the
> > impression that the X from deviceX and the X from triggerX are the
> > same value.
> >
> Fair point.
>
Agreed and applied.
Thanks,
Jonathan
Powered by blists - more mailing lists