linux-kernel - Re: [PATCH v4] scripts: checkpatch: warn on Rust panicking methods

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72mcJWPLrOtDPQpZcOO5Uwaw8+5z+StX-LMTVSDPvaVwjg@mail.gmail.com>
Date: Thu, 5 Feb 2026 22:00:44 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Dirk Behme <dirk.behme@...bosch.com>, Andy Whitcroft <apw@...onical.com>, 
	Joe Perches <joe@...ches.com>, Dwaipayan Ray <dwaipayanray1@...il.com>, 
	Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc: Dirk Behme <dirk.behme@...il.com>, Gary Guo <gary@...yguo.net>, 
	Onur Özkan <work@...rozkan.dev>, 
	Jkhall81 <jason.kei.hall@...il.com>, ojeda@...nel.org, rust-for-linux@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] scripts: checkpatch: warn on Rust panicking methods

On Thu, Feb 5, 2026 at 2:24 PM Dirk Behme <dirk.behme@...bosch.com> wrote:
>
> And how would a developer know that a `checkpatch.pl` warning on
> `unwrap()` is a false positive or not (i.e. is to be fixed)?

It depends on the context, like some other `checkpatch.pl`
errors/warnings, i.e. there is always some degree of developer
discretion. Or, at least, that is the way I think about
`checkpatch.pl` warnings, but maybe the maintainers think otherwise
(Cc'ing).

To give concrete advice, we could perhaps link to
https://rust.docs.kernel.org/kernel/error/type.Result.html#error-codes-in-c-and-rust,
for instance. (Please see my other reply on v5 about it).

Cheers,
Miguel