linux-kernel - Re: [PATCH v14 18/26] crypto: acomp, iaa - crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYQZGXue0F-S_Zqh@gondor.apana.org.au>
Date: Thu, 5 Feb 2026 12:14:17 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Kanchana P Sridhar <kanchana.p.sridhar@...el.com>
Cc: linux-kernel@...r.kernel.org, linux-mm@...ck.org, hannes@...xchg.org,
	yosry.ahmed@...ux.dev, nphamcs@...il.com, chengming.zhou@...ux.dev,
	usamaarif642@...il.com, ryan.roberts@....com, 21cnbao@...il.com,
	ying.huang@...ux.alibaba.com, akpm@...ux-foundation.org,
	senozhatsky@...omium.org, sj@...nel.org, kasong@...cent.com,
	linux-crypto@...r.kernel.org, davem@...emloft.net,
	clabbe@...libre.com, ardb@...nel.org, ebiggers@...gle.com,
	surenb@...gle.com, kristen.c.accardi@...el.com,
	vinicius.gomes@...el.com, giovanni.cabiddu@...el.com,
	wajdi.k.feghali@...el.com
Subject: Re: [PATCH v14 18/26] crypto: acomp, iaa - crypto_acomp integration
 of IAA Batching.

On Sat, Jan 24, 2026 at 07:35:29PM -0800, Kanchana P Sridhar wrote:
>
> @@ -291,6 +292,65 @@ static __always_inline int acomp_do_req_chain(struct acomp_req *req, bool comp)
>  	return acomp_reqchain_finish(req, err);
>  }
>  
> +static int acomp_do_req_batch_parallel(struct acomp_req *req, bool comp)
> +{
> +	struct crypto_acomp *tfm = crypto_acomp_reqtfm(req);
> +	unsigned long *bpwq_addr = acomp_request_ctx(req);
> +	wait_queue_head_t batch_parallel_wq;
> +	int ret;
> +
> +	init_waitqueue_head(&batch_parallel_wq);
> +	*bpwq_addr = (unsigned long)&batch_parallel_wq;
> +
> +	ret = comp ? tfm->compress(req) : tfm->decompress(req);
> +
> +	wait_event(batch_parallel_wq, tfm->batch_completed(req, comp));
> +
> +	if (req->slen < 0)
> +		ret |= -EINVAL;
> +
> +	return ret;
> +}

I don't think we should have this in acomp.  Just return EINPROGRESS
and let the user check each unit for the success/error.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt