linux-kernel - Re: [PATCH] Fix checkpatch.pl warnings in rtw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aYQuxJ2ruJJjI7Zt@stanley.mountain>
Date: Thu, 5 Feb 2026 08:46:44 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Haroen Tmimi <tmimiharoen@...il.com>
Cc: gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix checkpatch.pl warnings in rtw_ieee80211.c.

On Wed, Feb 04, 2026 at 07:41:33PM +0100, Haroen Tmimi wrote:
> 1. Fix "Yoda condition" style issues by moving constants to the right
>    side of the comparison (e.g., changing "_SUCCESS == val" to
>    "val == _SUCCESS").
> 
> 2. Change the _action_public_str array to "static const char * const"
>    to ensure the array entries are read-only, preventing accidental
>    modification of the pointers.
> 

These are unrelated things so they should be two patches.  But
apparently someone else already did at least part of this...

regards,
dan carpenter