linux-kernel - RE: [v6,net-next,15/15] net: fec: add AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB85107AE45D517D64F37FDE5D8899A@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Thu, 5 Feb 2026 06:04:07 +0000
From: Wei Fang <wei.fang@....com>
To: Jakub Kicinski <kuba@...nel.org>
CC: "ast@...nel.org" <ast@...nel.org>, "andrew+netdev@...n.ch"
	<andrew+netdev@...n.ch>, "davem@...emloft.net" <davem@...emloft.net>,
	"pabeni@...hat.com" <pabeni@...hat.com>, Clark Wang <xiaoning.wang@....com>,
	"john.fastabend@...il.com" <john.fastabend@...il.com>, "daniel@...earbox.net"
	<daniel@...earbox.net>, "sdf@...ichev.me" <sdf@...ichev.me>, Frank Li
	<frank.li@....com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "hawk@...nel.org" <hawk@...nel.org>,
	"horms@...nel.org" <horms@...nel.org>, "bpf@...r.kernel.org"
	<bpf@...r.kernel.org>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "imx@...ts.linux.dev"
	<imx@...ts.linux.dev>, Shenwei Wang <shenwei.wang@....com>
Subject: RE: [v6,net-next,15/15] net: fec: add AF_XDP zero-copy support

> > +	bdp->cbd_bufaddr = cpu_to_fec32(dma);
> > +	bdp->cbd_datlen = cpu_to_fec16(len);
> > +
> > +	if (fep->bufdesc_ex) {
> > +		struct bufdesc_ex *ebdp = (struct bufdesc_ex *)bdp;
> > +
> > +		if (fep->quirks & FEC_QUIRK_HAS_AVB)
> > +			estatus |= FEC_TX_BD_FTYPE(txq->bd.qid);
> > +
> > +		ebdp->cbd_bdu = 0;
> > +		ebdp->cbd_esc = cpu_to_fec32(estatus);
> > +	}
> > +
> > +	status |= (BD_ENET_TX_READY | BD_ENET_TX_TC);
> > +	bdp->cbd_sc = cpu_to_fec16(status);
> > +	dma_wmb();
> 
> Is there a missing dma_wmb() before setting BD_ENET_TX_READY?

Yes, my bad, I will fix it.