linux-kernel - Re: [PATCH] media: atomisp: add missing mutex in atomisp_vidioc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VcU+pm-6LHBWB=ieJcy4yKDfo=us6TAGp2kGJhRLsm_-Q@mail.gmail.com>
Date: Thu, 5 Feb 2026 08:26:00 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Ziyi Guo <n7l8m4@...orthwestern.edu>
Cc: Hans de Goede <hansg@...nel.org>, Mauro Carvalho Chehab <mchehab@...nel.org>, 
	Andy Shevchenko <andy@...nel.org>, Sakari Ailus <sakari.ailus@...ux.intel.com>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-media@...r.kernel.org, 
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: atomisp: add missing mutex in atomisp_vidioc_default()

On Thu, Feb 5, 2026 at 6:37 AM Ziyi Guo <n7l8m4@...orthwestern.edu> wrote:
>
> atomisp_vidioc_default() calls atomisp_exp_id_unlock(),
> atomisp_exp_id_capture(), and atomisp_inject_a_fake_event() without
> holding isp->mutex. However, all three functions have
> lockdep_assert_held(&isp->mutex) indicating callers must hold this lock.

Did you get a splat on real HW?

> Other ioctl handlers in the same driver (e.g., atomisp_start_streaming)
> properly acquire the mutex before operating on ISP state.
>
> Add mutex_lock()/mutex_unlock() around these three ioctl cases to fix the
> missing lock protection.

How did you find the issue?

-- 
With Best Regards,
Andy Shevchenko