linux-kernel - Re: [syzbot] [gfs2?] memory leak in gfs2_quota

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20260205063145.1039526-1-wangqing7171@gmail.com>
Date: Thu,  5 Feb 2026 14:31:45 +0800
From: Qing Wang <wangqing7171@...il.com>
To: syzbot+e57495fb65020ac7bca4@...kaller.appspotmail.com
Cc: agruenba@...hat.com,
	gfs2@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] [gfs2?] memory leak in gfs2_quota_init (2)

#syz test

diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c
index f6cd907b3ec6..1144720a17ff 100644
--- a/fs/gfs2/super.c
+++ b/fs/gfs2/super.c
@@ -149,9 +149,12 @@ int gfs2_make_fs_rw(struct gfs2_sbd *sdp)
 	error = gfs2_quota_init(sdp);
 	if (!error && gfs2_withdrawn(sdp))
 		error = -EIO;
-	if (!error)
-		set_bit(SDF_JOURNAL_LIVE, &sdp->sd_flags);
-	return error;
+	if (error) {
+		gfs2_quota_cleanup(sdp);
+		return error;
+	}
+	set_bit(SDF_JOURNAL_LIVE, &sdp->sd_flags);
+	return 0;
 }
 
 void gfs2_statfs_change_in(struct gfs2_statfs_change_host *sc, const void *buf)