linux-kernel - Re: [PATCH] arm64: dts: qcom: qcs6490: Add Thundercomm AI Mini PC G1 IoT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEQ9gEkH8mJu+kwghbFFwNi9RfbQ6CzykoYVJqa6YAL-74SaKQ@mail.gmail.com>
Date: Wed, 4 Feb 2026 16:04:56 -0800
From: Roger Shimizu <rosh@...ian.org>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: qcs6490: Add Thundercomm AI Mini PC G1 IoT

Thanks Konrad for the review!

On Wed, Feb 4, 2026 at 1:21 AM Konrad Dybcio
<konrad.dybcio@....qualcomm.com> wrote:
>
> On 1/31/26 11:31 AM, Roger Shimizu wrote:
> > Thundercomm AI MiniPC G1 IoT is single board computer with
> > AI capability based on Qualcomm QCS6490 platform.
> >
> > This device tree is confirmed to work as below:
> > - GPU
> > - HDMI output port
> > - PCIe M.2 port (for external Wi-Fi or 5G connectivity)
> > - UART / serial console port
> > - UFS
> > - USB Type-C port, with Display Port
> >
> > Signed-off-by: Roger Shimizu <rosh@...ian.org>
> > ---
>
> [...]
>
> > +/ {
> > +     model = "Thundercomm AI Mini PC G1 IoT";
> > +     compatible = "qcom,sc7280", "qcom,qcm6490";
>
> You need to add a board-specific compatible here, see:
>
> Documentation/devicetree/bindings/arm/qcom.yaml

Thanks for the hint!
I'll add it in v2 series.

> > +     chassis-type = "embedded";
>
> The allowed values are:
>
>     enum:
>       - desktop
>       - laptop
>       - convertible
>       - server
>       - all-in-one
>       - tablet
>       - handset
>       - watch
>       - embedded
>       - television
>       - spectacles
>
> I think it's more of a desktop, but a) that's minor and b) you could
> argue either way

The device name indicates it's Mini PC, so desktop is better.

> [...]
>
> > +             vreg_s1b_1p872: smps1 {
> > +                     regulator-name = "vreg_s1b_1p872";
> > +                     regulator-min-microvolt = <1840000>;
> > +                     regulator-max-microvolt = <2040000>;
>
> Have you cross-checked the regulator settings against the original
> vendor-provided sw?

No. Those are from RB3 Gen2. So far there's no issue.
If there's an issue, we can fix it later.

> [...]
>
> > +&gpu_zap_shader {
> > +     firmware-name = "qcom/qcs6490/a660_zap.mbn";
>
> I'm assuming this means the thing can take Qualcomm- (vs OEM-)signed firmware
> Could you please confirm that's the case?

Yes, so far I don't find issue by using gpu firmware from this path.

> [...]
>
> > +&pon_pwrkey {
> > +     status = "okay";
> > +};
>
> This one is already enabled

May I know where it's enabled?
>From my search, pon_pwrkey is defined in:
arch/arm64/boot/dts/qcom/pmk8350.dtsi, which is disabled.

-Roger