linux-kernel - Re: [PATCH 1/3] dt-bindings: usb: axiado,ax3000-udc: Add Axiado UDC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd3e01c-80e6-4691-b80e-95457aa92d93@kernel.org>
Date: Thu, 5 Feb 2026 08:42:06 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Vladimir Moravcevic <vmoravcevic@...ado.com>,
 Krutik Shah <krutikshah@...ado.com>, Prasad Bolisetty
 <pbolisetty@...ado.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: linux-usb@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
 openbmc@...ts.ozlabs.org
Subject: Re: [PATCH 1/3] dt-bindings: usb: axiado,ax3000-udc: Add Axiado UDC

On 02/02/2026 14:16, Vladimir Moravcevic wrote:
> Add Axiado ax3000-udc (for USB v2.0 ports) and
> ax3000-udc-gen3 (for USB v3.0 ports)
> compatible string for AX3000 SoC.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

> 
> Co-developed-by: Krutik Shah <krutikshah@...ado.com>
> Signed-off-by: Krutik Shah <krutikshah@...ado.com>
> Co-developed-by: Prasad Bolisetty <pbolisetty@...ado.com>
> Signed-off-by: Prasad Bolisetty <pbolisetty@...ado.com>

Please use only real authors here.

> Signed-off-by: Vladimir Moravcevic <vmoravcevic@...ado.com>
> ---
>  .../devicetree/bindings/usb/axiado,ax3000-udc.yaml | 59 ++++++++++++++++++++++
>  1 file changed, 59 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/axiado,ax3000-udc.yaml b/Documentation/devicetree/bindings/usb/axiado,ax3000-udc.yaml
> new file mode 100644
> index 000000000000..15658b5c924f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/axiado,ax3000-udc.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/usb/axiado,ax3000-udc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Axiado AX3000 USB Device Controller (Corigine-based)
> +
> +maintainers:
> +  - Krutik Shah <krutikshah@...ado.com>
> +  - Prasad Bolisetty <pbolisetty@...ado.com>
> +  - Vladimir Moravcevic <vmoravcevic@...ado.com>
> +
> +description: |
> +  Axiado AX3000 USB Device Controller (UDC) is used on
> +  AX3000 SoCs and evaluation boards. This controller is based on a
> +  Corigine USB IP core and provides SuperSpeed (5 Gb/s), High-Speed
> +  (480 Mb/s). It supports control, bulk, interrupt, and isochronous
> +  transfer types across multiple configurable endpoints. The node
> +  describes the memory-mapped register region, interrupt line, and
> +  other required properties for the UDC hardware.

Drop last sentence, completely redundant. There is no point to explain
what the binding or DT are.

> +
> +properties:
> +  compatible:
> +    enum:
> +      - axiado,ax3000-udc         # AX3000 UDC (USB 2.0/High-Speed)

-gen2

in such case, but I don't like these names. They are awfully
non-hardware looking.

> +      - axiado,ax3000-udc-gen3    # AX3000 UDC (USB 3.0/SuperSpeed)
> +
> +  reg:
> +    maxItems: 1
> +    description: Base address and size of the UDC register space.

Drop description, redundant

> +
> +  interrupts:
> +    maxItems: 1
> +    description: Interrupt line for the UDC.

Drop description

> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
Best regards,
Krzysztof