linux-kernel - Re: [PATCH v2 1/1] mtd: cfi_cmdset_0001: Factor out do_write_buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87a4xnfu8j.fsf@bootlin.com>
Date: Thu, 05 Feb 2026 09:51:56 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: linux-mtd@...ts.infradead.org,  linux-kernel@...r.kernel.org,  Richard
 Weinberger <richard@....at>,  Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH v2 1/1] mtd: cfi_cmdset_0001: Factor out
 do_write_buffer_locked() to reduce stack frame

Hi Andy,

On 04/02/2026 at 23:12:00 +02, Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> On Wed, Feb 04, 2026 at 02:25:27AM +0100, Andy Shevchenko wrote:
>> Compiler is not happy about used stack frame:
>> 
>> drivers/mtd/chips/cfi_cmdset_0001.c: In function 'do_write_buffer':
>> drivers/mtd/chips/cfi_cmdset_0001.c:1887:1: error: the frame size of 1296 bytes is larger than 1280 bytes [-Werror=frame-larger-than=]
>> 
>> Fix this by factoring out do_write_buffer_locked().
>
> My gosh, I already sent a v2 earlier and there were some replies,
> I need to check...

I'm not sure I get what you mean here? I got no reply (in my inbox) to
your v2. I am letting a bit of time for Vignesh to take a look, but I
know he's busy so I might take it nevertheless by the end of the week as
we are approaching the merge window.

Cheers,
Miquèl