linux-kernel - Re: [PATCH] MIPS: tools: relocs: Ship a definition of R_MIPS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2602050110020.17548@angie.orcam.me.uk>
Date: Thu, 5 Feb 2026 01:26:39 +0000 (GMT)
From: "Maciej W. Rozycki" <macro@...am.me.uk>
To: Yao Zi <me@...ao.cc>
cc: Nathan Chancellor <nathan@...nel.org>, Ard Biesheuvel <ardb@...nel.org>, 
    Thomas Bogendoerfer <tsbogend@...ha.franken.de>, 
    linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: tools: relocs: Ship a definition of R_MIPS_PC32

On Tue, 3 Feb 2026, Yao Zi wrote:

> > I interpret that to mean that the kallsyms patch should work fine since
> > the toolchain can handle these relocations? It is just building the
> > relocs tool against an older glibc or musl that does not have the
> > R_MIPS_PC32 definition that is broken? Or am I misunderstanding
> > something?
> 
> Yes, this patch is only meant to fix building of relocs tool. I don't
> think there are problems about toolchain supporting since R_MIPS_PC32
> has been in binutils for a long time, as Nathan found, since 2004. The

 Since Y2K to be exact:

commit bb2d6cd7b19cd82313963d2d878a94e6e85a38b6
Author: Geoffrey Keating <geoffk@...ffk.org>
Date:   Sat Mar 11 02:16:25 2000 +0000

[...]
    In include/elf:
    	* mips.h: Add R_MIPS_GNU_REL_HI16, R_MIPS_GNU_REL_LO16,
     	R_MIPS_GNU_REL16_S2, R_MIPS_PC64 and R_MIPS_PC32 relocation
     	numbers.

> situation is that it's likely to have a toolchain supporting
> R_MIPS_PC32, while elf.h on the build machine doesn't have its
> definition. And after ff79d31eb536 ("mips: Add support for PC32
> relocations in vmlinux"), the relocs tool started to require a
> definition of R_MIPS_PC32 to build.

 But where does ff79d31eb536 come from?  I can't see it on Linus's master 
and you can't refer an SHA-1 ID from another repo in a 'Fixes:' tag AFAIK, 
as it's going to change as a commit is merged.  Also can't you get the fix 
folded into the offending commit since it hasn't been merged yet?

  Maciej