[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAJKbuCY8Xc0HMfpVG1FCjW_-QE-Lm_qKVxFht7Dj=18XoGjwUA@mail.gmail.com>
Date: Thu, 5 Feb 2026 14:21:55 +0530
From: ashish yadav <ashishyadav78@...il.com>
To: Guenter Roeck <linux@...ck-us.net>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
"Ashish.Yadav@...ineon.com" <ashish.yadav@...ineon.com>, devicetree@...r.kernel.org
Subject: Re: [PATCH 0/2] Add support for Infineon Digital Multi-phase
Controllers XDPE1A2G5B/7B
Hi Guenter,
Thank you for taking the time to review and provide feedback.
I appreciate your input and insights.
Please find my comments inline below.
Best Regards,
Ashish Yadav
On Mon, Feb 2, 2026 at 8:39 PM Guenter Roeck <linux@...ck-us.net> wrote:
>
> On 2/2/26 00:03, ASHISH YADAV wrote:
> > From: Ashish Yadav <ashish.yadav@...ineon.com>
> >
> > Hi ,
> >
> > These patches add support for Infineon Digital Multi-phase Controllers
> > XDPE1A2G5B and XDPE1A2G7B.
> >
> > XDPE1A2G5B controller supports Linear Data format for VOUT using VOUT_MODE
> > command.
> > XDPE1A2G7B controller supports Linear and VID Data format for VOUT using
> > VOUT_MODE command.
> >
>
> This suggests that calling the identification code is not necessary for
> XDPE1A2G5B. Please modify the driver accordingly.
>
ACK, We will take care of this in the next release.
> Thanks,
> Guenter
>
> > In case of vid mode in XDPE1A2G7B controller, NVIDIA PWM VID vrm_version
> > is supported:
> > Vout = 5mV * (VID-1) + 195mV
> >
> > With Best Regards
> > Ashish Yadav
> >
> > Ashish Yadav (2):
> > dt-bindings: trivial-devices: Add support for XDPE1A2G5B/7B
> > hwmon:(pmbus/xdpe1a2g7b) Add support for xdpe1a2g5b/7b controllers
> >
> > .../devicetree/bindings/trivial-devices.yaml | 3 +
> > drivers/hwmon/pmbus/Kconfig | 9 ++
> > drivers/hwmon/pmbus/Makefile | 1 +
> > drivers/hwmon/pmbus/pmbus.h | 2 +-
> > drivers/hwmon/pmbus/pmbus_core.c | 4 +
> > drivers/hwmon/pmbus/xdpe1a2g7b.c | 115 ++++++++++++++++++
> > 6 files changed, 133 insertions(+), 1 deletion(-)
> > create mode 100644 drivers/hwmon/pmbus/xdpe1a2g7b.c
> >
>
Powered by blists - more mailing lists