linux-kernel - Re: [PATCH v3 4/4] staging: greybus: resolved checkpatch checks for light.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <DG6XM4KTQQBU.3257ITEZ9ZF19@linaro.com>
Date: Thu, 05 Feb 2026 09:47:55 +0000
From: Rui Miguel Silva <rui.silva@...aro.org>
To: "Rachit Dhar" <rchtdhr@...il.com>, "Rui Miguel Silva" <rmfrfs@...il.com>
Cc: "Johan Hovold" <johan@...nel.org>, "Alex Elder" <elder@...nel.org>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
 <greybus-dev@...ts.linaro.org>, <linux-staging@...ts.linux.dev>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 4/4] staging: greybus: resolved checkpatch checks for
 light.c

Hey Rachit,
Thanks for the patch. And the sending corrections along the path.

On Wed Feb 4, 2026 at 6:31 PM WET, Rachit Dhar wrote:

> Added comment to mutex declarations, to resolve checkpatch.pl checks.
>
> Signed-off-by: Rachit Dhar <rchtdhr@...il.com>
> ---
>  drivers/staging/greybus/light.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c
> index e509fdc715db..1f2faa6d545d 100644
> --- a/drivers/staging/greybus/light.c
> +++ b/drivers/staging/greybus/light.c
> @@ -37,7 +37,7 @@ struct gb_channel {
>  	bool				releasing;
>  	bool				strobe_state;
>  	bool				active;
> -	struct mutex			lock;
> +	struct mutex			lock; /* protects gb_channel->active */
>  };
>  
>  struct gb_light {
> @@ -59,7 +59,7 @@ struct gb_lights {
>  	struct gb_connection	*connection;
>  	u8			lights_count;
>  	struct gb_light		*lights;
> -	struct mutex		lights_lock;
> +	struct mutex		lights_lock; /* protects gb_lights->lights */
>  };
>  


This LGTM.

Acked-by: Rui Miguel Silva <rui.silva@...aro.org>

Cheers,
    Rui

>  static void gb_lights_channel_free(struct gb_channel *channel);
> -- 
> 2.43.0