linux-kernel - Re: [PATCH v2 1/3] dt-bindings: usb: introduce fsl,imx-dwc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <w4uvuyj6qpufajyo7cibwmhayfhkspg5pybbqlxvizv53qbyhw@gmrfwbqli57p>
Date: Thu, 5 Feb 2026 18:50:02 +0800
From: Xu Yang <xu.yang_2@....com>
To: Rob Herring <robh@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, 
	Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, Frank Li <frank.li@....com>, 
	Li Jun <jun.li@....com>, Thinh Nguyen <Thinh.Nguyen@...opsys.com>, 
	linux-usb@...r.kernel.org, devicetree@...r.kernel.org, imx@...ts.linux.dev, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: usb: introduce fsl,imx-dwc3

On Wed, Feb 04, 2026 at 07:46:11AM -0600, Rob Herring wrote:
> On Wed, Feb 4, 2026 at 5:05 AM Xu Yang <xu.yang_2@....com> wrote:
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - fsl,imx8mp-dwc3
> 
> You can't reuse the same compatible for a new binding.

OK. Will use a different name.

> 
> > +          - fsl,imx94-dwc3
> > +          - fsl,imx95-dwc3
> > +      - const: fsl,imx-dwc3
> 
> Drop. If you want a fallback, use the 1st SoC's compatible.

OK.

> 
> > +
> > +  reg:
> > +    items:
> > +      - description: DWC3 core registers
> > +      - description: HSIO Block Control registers
> > +      - description: Wrapper registers of dwc3 core
> > +

[...]

> > +      power-domains = <&scmi_devpd 13>;   //IMX94_PD_HSIO_TOP
> > +      phys = <&usb3_phy>, <&usb3_phy>;
> > +      phy-names = "usb2-phy", "usb3-phy";
> > +      snps,gfladj-refclk-lpm-sel-quirk;
> > +      snps,parkmode-disable-ss-quirk;
> > +      status = "disabled";
> 
> Examples should be enabled.

OK.

Thanks,
Xu Yang