linux-kernel - Re: [PATCH 2/2] i2c: amd8111: switch to devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYR4E9UmuQ4Wx_ro@zenone.zhora.eu>
Date: Thu, 5 Feb 2026 12:03:51 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Filippo Muscherà <filippo.muschera@...il.com>
Cc: jdelvare@...e.com, linux-i2c@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] i2c: amd8111: switch to devm_ functions

Hi Filippo,

On Mon, Feb 02, 2026 at 02:13:04PM +0100, Filippo Muscherà wrote:
> Use devm_kzalloc() to manage the memory allocation of the smbus structure
> and devm_request_region() to manage the I/O port region.

Merged to i2c/i2c-host-2.

Just a few notes for the next time:

1. I prefer two different patches for devm_kzalloc() and
   devm_request_region().

2. For series with more than one patch, I'd like to have a cover
   letter to introduce the series.

Thanks,
Andi

> This simplifies the error handling paths in the probe function by removing
> manual cleanup and allows for the removal of the explicit cleanup in the
> remove function.
> 
> Signed-off-by: Filippo Muscherà <filippo.muschera@...il.com>