linux-kernel - Re: [PATCH] mmc: mtk-sd: disable new_tx/rx and modify related settings for mt8189

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <33719d8d-af95-49ae-bc5e-247784529d12@collabora.com>
Date: Thu, 5 Feb 2026 12:47:31 +0100
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Cathy Xu <ot_cathy.xu@...iatek.com>,
 Chaotian Jing <chaotian.jing@...iatek.com>,
 Ulf Hansson <ulf.hansson@...aro.org>,
 Matthias Brugger <matthias.bgg@...il.com>
Cc: linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 Mengqi Zhang <Mengqi.Zhang@...iatek.com>,
 Wenbin Mei <Wenbin.Mei@...iatek.com>, Andy-ld Lu <Andy-ld.Lu@...iatek.com>,
 Yong Mao <yong.mao@...iatek.com>
Subject: Re: [PATCH] mmc: mtk-sd: disable new_tx/rx and modify related
 settings for mt8189

Il 04/02/26 03:06, Cathy Xu ha scritto:
> Disable new_tx/rx and modify related settings helps avoid data
> transmission instability, and better compatibility for mt8189.
> 
> Signed-off-by: Cathy Xu <ot_cathy.xu@...iatek.com>

Needs a fixes tag. Please add the relevant one and resend.

Thanks,
Angelo

> ---
>   drivers/mmc/host/mtk-sd.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 302ac8529c4f..b2680cc054bd 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -682,15 +682,15 @@ static const struct mtk_mmc_compatible mt8189_compat = {
>   	.needs_top_base = true,
>   	.pad_tune_reg = MSDC_PAD_TUNE0,
>   	.async_fifo = true,
> -	.data_tune = true,
> +	.data_tune = false,
>   	.busy_check = true,
>   	.stop_clk_fix = true,
> -	.stop_dly_sel = 1,
> -	.pop_en_cnt = 2,
> +	.stop_dly_sel = 3,
> +	.pop_en_cnt = 8,
>   	.enhance_rx = true,
>   	.support_64g = true,
> -	.support_new_tx = true,
> -	.support_new_rx = true,
> +	.support_new_tx = false,
> +	.support_new_rx = false,
>   	.support_spm_res_release = true,
>   };
>